thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug with temporary projection parts deletion

Browse Source
This commit is contained in:
alesapin 2022-11-08 15:33:23 +01:00
parent 658036d179
commit 6f059be748
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/Storages/MergeTree/IMergeTreeDataPart.cpp
View File

@ -1629,6 +1629,12 @@ void IMergeTreeDataPart::remove()
auto can_remove_callback = [this] () auto can_remove_callback = [this] ()
{ {
if (isProjectionPart() && is_temp)
{
LOG_TRACE(storage.log, "Temporary projection part {} can be removed", name);
return CanRemoveDescription{.can_remove_anything = true, .files_not_to_remove = {} };
}
auto [can_remove, files_not_to_remove] = canRemovePart(); auto [can_remove, files_not_to_remove] = canRemovePart();
if (!can_remove) if (!can_remove)
LOG_TRACE(storage.log, "Blobs of part {} cannot be removed", name); LOG_TRACE(storage.log, "Blobs of part {} cannot be removed", name);
@ -1642,8 +1648,8 @@ void IMergeTreeDataPart::remove()
if (!isStoredOnDisk()) if (!isStoredOnDisk())
return; return;
if (isProjectionPart()) if (isProjectionPart() && !is_temp)
LOG_WARNING(storage.log, "Projection part {} should be removed by its parent {}.", name, parent_part->name); throw Exception(ErrorCodes::LOGICAL_ERROR, "Projection part {} should be removed by its parent {}.", name, parent_part->name);
metadata_manager->deleteAll(false); metadata_manager->deleteAll(false);
metadata_manager->assertAllDeleted(false); metadata_manager->assertAllDeleted(false);