Fix flaky test

This commit is contained in:
Tuan Pham Anh 2024-10-03 01:02:09 +00:00
parent eef838bade
commit 709ac58840

View File

@ -17,7 +17,10 @@ node3 = cluster.add_instance(
"node3", main_configs=["configs/remote_servers.xml"], with_zookeeper=True "node3", main_configs=["configs/remote_servers.xml"], with_zookeeper=True
) )
node4 = cluster.add_instance( node4 = cluster.add_instance(
"node4", main_configs=["configs/remote_servers.xml"], with_zookeeper=True "node4",
main_configs=["configs/remote_servers.xml"],
with_zookeeper=True,
stay_alive=True,
) )
@ -47,25 +50,28 @@ def test_ddl_worker_replicas(started_cluster):
lines = list(result.split("\n")) lines = list(result.split("\n"))
assert len(lines) == 1 assert len(lines) == 1
print(f"Test: {replica} {lines[0]}")
parts = list(lines[0].split("\t")) parts = list(lines[0].split("\t"))
assert len(parts) == 3 assert len(parts) == 3
assert parts[0] == "active" assert parts[0] == "active"
assert len(parts[1]) != 0 assert len(parts[1]) != 0
assert len(parts[2]) != 0 assert len(parts[2]) != 0
node4.stop() try:
node4.stop_clickhouse()
# wait for node4 active path is removed # wait for node4 active path is removed
node1.query_with_retry( node1.query_with_retry(
sql=f"SELECT count() FROM system.zookeeper WHERE path='/clickhouse/task_queue/replicas/node4:9000'", sql=f"SELECT count() FROM system.zookeeper WHERE path='/clickhouse/task_queue/replicas/node4:9000'",
check_callback=lambda result: result == 0, check_callback=lambda result: result == 0,
) )
result = node1.query_with_retry( result = node1.query_with_retry(
f"SELECT name, value, ephemeralOwner FROM system.zookeeper WHERE path='/clickhouse/task_queue/replicas/node4:9000'" f"SELECT name, value, ephemeralOwner FROM system.zookeeper WHERE path='/clickhouse/task_queue/replicas/node4:9000'"
).strip() ).strip()
lines = list(result.split("\n")) lines = list(result.split("\n"))
assert len(lines) == 1 assert len(lines) == 1
assert len(lines[0]) == 0 assert len(lines[0]) == 0
finally:
node4.start_clickhouse()