thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent types too large for UInt64 from being used

Browse Source
This commit is contained in:
Salvatore Mesoraca 2023-04-20 11:04:49 +02:00
parent e2d4e08c3b
commit 70a8d7ef08
No known key found for this signature in database
GPG Key ID: 0567E50A25403074
3 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/Functions/transform.cpp
View File

@ -144,6 +144,7 @@ namespace
"transform(T, Array(T), Array(U), U) -> U; "
"or transform(T, Array(T), Array(T)) -> T; where T and U are types.",
getName());
checkAllowedType(ret);
return ret;
}
else
@ -156,6 +157,7 @@ namespace
"transform(T, Array(T), Array(U), U) -> U; "
"or transform(T, Array(T), Array(T)) -> T; where T and U are types.",
getName());
checkAllowedType(ret);
return ret;
}
}
@ -633,6 +635,24 @@ namespace
}
}
static void checkAllowedType(const DataTypePtr & dt)
{
if (dt->isNullable())
checkAllowedTypeHelper(static_cast<const DataTypeNullable *>(dt.get())->getNestedType());
else
checkAllowedTypeHelper(dt);
}
static void checkAllowedTypeHelper(const DataTypePtr & dt)
{
if (isStringOrFixedString(dt))
return;
auto dtsize = dt->getMaximumSizeOfValueInMemory();
if (dtsize <= sizeof(UInt64))
return;
throw Exception(ErrorCodes::BAD_ARGUMENTS, "Unexpected type {} in function 'transform'", dt->getName());
}
/// Can be called from different threads. It works only on the first call.
void initialize(const ColumnsWithTypeAndName & arguments, const DataTypePtr & result_type) const
{

1
tests/queries/0_stateless/02542_transform_new.reference
View File

@ -29,3 +29,4 @@ sep4
8000
sep5
8000
sep6

4
tests/queries/0_stateless/02542_transform_new.sql
View File

@ -29,3 +29,7 @@ select 'sep4';
SELECT transform(8000, [1], [toDecimal32(2, 1)]);
select 'sep5';
SELECT transform(toDecimal32(8000,0), [1], [toDecimal32(2, 1)]);
select 'sep6';
SELECT transform(-9223372036854775807, [-1], [toDecimal32(1024, 3)]) FROM system.numbers LIMIT 7; -- { serverError BAD_ARGUMENTS }
SELECT [NULL, NULL, NULL, NULL], transform(number, [2147483648], [toDecimal32(1, 2)]) AS x FROM numbers(257) WHERE materialize(10); -- { serverError BAD_ARGUMENTS }
SELECT transform(-2147483649, [1], [toDecimal32(1, 2)]) GROUP BY [1] WITH TOTALS; -- { serverError BAD_ARGUMENTS }