Fix tidy build

This commit is contained in:
avogar 2024-08-14 20:22:19 +00:00
parent fc23f1c1ff
commit 7251bc59f8
3 changed files with 7 additions and 7 deletions

View File

@ -250,7 +250,7 @@ void ColumnObject::insertData(const char *, size_t)
throw Exception(ErrorCodes::NOT_IMPLEMENTED, "Method insertData is not supported for {}", getName());
}
ColumnDynamic * ColumnObject::tryToAddNewDynamicPath(const std::string_view path)
ColumnDynamic * ColumnObject::tryToAddNewDynamicPath(std::string_view path)
{
if (dynamic_paths.size() == max_dynamic_paths)
return nullptr;
@ -263,7 +263,7 @@ ColumnDynamic * ColumnObject::tryToAddNewDynamicPath(const std::string_view path
return it_ptr->second;
}
void ColumnObject::addNewDynamicPath(const std::string_view path)
void ColumnObject::addNewDynamicPath(std::string_view path)
{
if (!tryToAddNewDynamicPath(path))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Cannot add new dynamic path as the limit ({}) on dynamic paths is reached", max_dynamic_paths);
@ -605,7 +605,7 @@ void ColumnObject::insertFromSharedDataAndFillRemainingDynamicPaths(const DB::Co
}
}
void ColumnObject::serializePathAndValueIntoSharedData(ColumnString * shared_data_paths, ColumnString * shared_data_values, const std::string_view path, const IColumn & column, size_t n)
void ColumnObject::serializePathAndValueIntoSharedData(ColumnString * shared_data_paths, ColumnString * shared_data_values, std::string_view path, const IColumn & column, size_t n)
{
/// Don't store Null values in shared data. We consider Null value equivalent to the absence
/// of this path in the row because we cannot distinguish these 2 cases for dynamic paths.

View File

@ -215,15 +215,15 @@ public:
/// Try to add new dynamic path. Returns pointer to the new dynamic
/// path column or nullptr if limit on dynamic paths is reached.
ColumnDynamic * tryToAddNewDynamicPath(const std::string_view path);
ColumnDynamic * tryToAddNewDynamicPath( std::string_view path);
/// Throws an exception if cannot add.
void addNewDynamicPath(const std::string_view path);
void addNewDynamicPath(std::string_view path);
void setDynamicPaths(const std::vector<String> & paths);
void setMaxDynamicPaths(size_t max_dynamic_paths_);
void setStatistics(const StatisticsPtr & statistics_) { statistics = statistics_; }
void serializePathAndValueIntoSharedData(ColumnString * shared_data_paths, ColumnString * shared_data_values, const std::string_view path, const IColumn & column, size_t n);
void serializePathAndValueIntoSharedData(ColumnString * shared_data_paths, ColumnString * shared_data_values, std::string_view path, const IColumn & column, size_t n);
void deserializeValueFromSharedData(const ColumnString * shared_data_values, size_t n, IColumn & column) const;
/// Paths in shared data are sorted in each row. Use this method to find the lower bound for specific path in the row.

View File

@ -100,7 +100,7 @@ enum class BinaryTypeIndex : uint8_t
/// In future we can introduce more arguments in the JSON data type definition.
/// To support such changes, use versioning in the serialization of JSON type.
static const UInt8 TYPE_JSON_SERIALIZATION_VERSION = 0;
const UInt8 TYPE_JSON_SERIALIZATION_VERSION = 0;
BinaryTypeIndex getBinaryTypeIndex(const DataTypePtr & type)
{