thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 07:31:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed incompatibility when versions prior to 18.12.17 are used on remote servers and newer is used on initiating server, and GROUP BY both fixed and non-fixed keys, and when two-level group by method is activated [#CLICKHOUSE-4035]

Browse Source
This commit is contained in:
Alexey Milovidov 2018-10-13 02:43:25 +03:00
parent 98859f232b
commit 72e2996e3e
1 changed files with 22 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
dbms/src/Client/MultiplexedConnections.cpp
View File

@ -87,37 +87,36 @@ void MultiplexedConnections::sendQuery(
if (sent_query) if (sent_query)
throw Exception("Query already sent.", ErrorCodes::LOGICAL_ERROR); throw Exception("Query already sent.", ErrorCodes::LOGICAL_ERROR);
if (replica_states.size() > 1) Settings modified_settings = settings;
for (auto & replica : replica_states)
{ {
Settings query_settings = settings; if (!replica.connection)
query_settings.parallel_replicas_count = replica_states.size(); throw Exception("MultiplexedConnections: Internal error", ErrorCodes::LOGICAL_ERROR);
for (size_t i = 0; i < replica_states.size(); ++i) if (replica.connection->getServerRevision() < DBMS_MIN_REVISION_WITH_CURRENT_AGGREGATION_VARIANT_SELECTION_METHOD)
{ {
Connection * connection = replica_states[i].connection; /// Disable two-level aggregation due to version incompatibility.
if (connection == nullptr) modified_settings.group_by_two_level_threshold = 0;
throw Exception("MultiplexedConnections: Internal error", ErrorCodes::LOGICAL_ERROR); modified_settings.group_by_two_level_threshold_bytes = 0;
}
}
if (connection->getServerRevision() < DBMS_MIN_REVISION_WITH_CURRENT_AGGREGATION_VARIANT_SELECTION_METHOD) size_t num_replicas = replica_states.size();
{ if (num_replicas > 1)
/// Disable two-level aggregation due to version incompatibility. {
query_settings.group_by_two_level_threshold = 0; /// Use multiple replicas for parallel query processing.
query_settings.group_by_two_level_threshold_bytes = 0; modified_settings.parallel_replicas_count = num_replicas;
for (size_t i = 0; i < num_replicas; ++i)
/// NOTE: It's ok that we disable it for all following connections (even if it wasn't needed). {
} modified_settings.parallel_replica_offset = i;
replica_states[i].connection->sendQuery(query, query_id, stage, &modified_settings, client_info, with_pending_data);
query_settings.parallel_replica_offset = i;
connection->sendQuery(query, query_id, stage, &query_settings, client_info, with_pending_data);
} }
} }
else else
{ {
Connection * connection = replica_states[0].connection; /// Use single replica.
if (connection == nullptr) replica_states[0].connection->sendQuery(query, query_id, stage, &modified_settings, client_info, with_pending_data);
throw Exception("MultiplexedConnections: Internal error", ErrorCodes::LOGICAL_ERROR);
connection->sendQuery(query, query_id, stage, &settings, client_info, with_pending_data);
} }
sent_query = true; sent_query = true;