thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed tests

Browse Source
This commit is contained in:
Maksim Kita 2021-05-22 17:15:39 +03:00
parent ed443c8941
commit 72fbb2dd54
2 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Functions/IFunction.h
View File

@ -155,12 +155,7 @@ public:
*/
virtual bool isSuitableForConstantFolding() const { return true; }
/** Some functions like ignore(...) or toTypeName(...) always return constant result which doesn't depend on arguments.
* In this case we can calculate result and assume that it's constant in stream header.
* There is no need to implement function if it has zero arguments.
* Must return ColumnConst with single row or nullptr.
*/
virtual ColumnPtr getConstantResultForArguments(const ColumnsWithTypeAndName & /* columns */ ) const { return nullptr; }
virtual ColumnPtr getConstantResultForArguments(const ColumnsWithTypeAndName & /* columns */) const { return nullptr; }
/** Function is called "injective" if it returns different result for different values of arguments.
* Example: hex, negate, tuple...

11
src/Interpreters/ExpressionActions.cpp
View File

@ -55,15 +55,6 @@ ExpressionActions::ExpressionActions(ActionsDAGPtr actions_dag_, const Expressio
actions_dag->compileExpressions(settings.min_count_to_compile_expression);
#endif
std::cerr << "ExpressionActions::ExpressionActions " << this << std::endl;
std::cerr << actions_dag->dumpDAG() << std::endl;
auto actions_required_columns = actions_dag->getRequiredColumns();
for (auto & required_column : actions_required_columns)
{
std::cerr << "Required column " << required_column.name << " type " << required_column.type->getName() << std::endl;
}
linearizeActions();
if (settings.max_temporary_columns && num_columns > settings.max_temporary_columns)
@ -449,8 +440,6 @@ static void executeAction(const ExpressionActions::Action & action, ExecutionCon
void ExpressionActions::execute(Block & block, size_t & num_rows, bool dry_run) const
{
std::cerr << "ExpressionActions::execute " << this << std::endl;
ExecutionContext execution_context
{
.inputs = block.data,