thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused parallel replicas coordinator in query info

Browse Source
This commit is contained in:
Igor Nikonov 2023-08-27 22:12:39 +00:00
parent a0ff7a97c9
commit 7368bf65b3
2 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/Interpreters/ClusterProxy/executeQuery.cpp
View File

@ -318,20 +318,11 @@ void executeQueryWithParallelReplicas(
} }
auto coordinator = std::make_shared<ParallelReplicasReadingCoordinator>(all_replicas_count); auto coordinator = std::make_shared<ParallelReplicasReadingCoordinator>(all_replicas_count);
/// This is a little bit weird, but we construct an "empty" coordinator without
/// any specified reading/coordination method (like Default, InOrder, InReverseOrder)
/// Because we will understand it later during QueryPlan optimization
/// So we place a reference to the coordinator to some common plane like QueryInfo
/// to then tell it about the reading method we chose.
query_info.coordinator = coordinator;
auto external_tables = new_context->getExternalTables(); auto external_tables = new_context->getExternalTables();
auto read_from_remote = std::make_unique<ReadFromParallelRemoteReplicasStep>( auto read_from_remote = std::make_unique<ReadFromParallelRemoteReplicasStep>(
query_ast, query_ast,
new_cluster, new_cluster,
coordinator, std::move(coordinator),
stream_factory.header, stream_factory.header,
stream_factory.processed_stage, stream_factory.processed_stage,
main_table, main_table,

3
src/Storages/SelectQueryInfo.h
View File

@ -10,7 +10,6 @@
#include <Planner/PlannerContext.h> #include <Planner/PlannerContext.h>
#include <QueryPipeline/StreamLocalLimits.h> #include <QueryPipeline/StreamLocalLimits.h>
#include <Storages/ProjectionsDescription.h> #include <Storages/ProjectionsDescription.h>
#include <Storages/MergeTree/ParallelReplicasReadingCoordinator.h>
#include <memory> #include <memory>
@ -211,8 +210,6 @@ struct SelectQueryInfo
/// should we use custom key with the cluster /// should we use custom key with the cluster
bool use_custom_key = false; bool use_custom_key = false;
mutable ParallelReplicasReadingCoordinatorPtr coordinator;
TreeRewriterResultPtr syntax_analyzer_result; TreeRewriterResultPtr syntax_analyzer_result;
/// This is an additional filer applied to current table. /// This is an additional filer applied to current table.