From 746b7d0e131cb31af250f90a0cbea9cf8206498d Mon Sep 17 00:00:00 2001 From: nikitamikhaylov Date: Tue, 6 Oct 2020 22:01:55 +0300 Subject: [PATCH] better test + fix writePrefix in JSONCompact --- .../Formats/Impl/JSONCompactEachRowRowOutputFormat.cpp | 2 +- src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.h | 2 +- tests/queries/0_stateless/01514_parallel_formatting.sql | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.cpp b/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.cpp index 6efecc1b978..11134499984 100644 --- a/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.cpp +++ b/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.cpp @@ -68,7 +68,7 @@ void JSONCompactEachRowRowOutputFormat::writeTotals(const Columns & columns, siz writeCString("]\n", out); } -void JSONCompactEachRowRowOutputFormat::writePrefix() +void JSONCompactEachRowRowOutputFormat::doWritePrefix() { if (with_names) { diff --git a/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.h b/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.h index eb426bec15d..3d4b80247b8 100644 --- a/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.h +++ b/src/Processors/Formats/Impl/JSONCompactEachRowRowOutputFormat.h @@ -25,7 +25,7 @@ public: String getName() const override { return "JSONCompactEachRowRowOutputFormat"; } - void writePrefix() override; + void doWritePrefix() override; void writeBeforeTotals() override {} void writeTotals(const Columns & columns, size_t row_num) override; diff --git a/tests/queries/0_stateless/01514_parallel_formatting.sql b/tests/queries/0_stateless/01514_parallel_formatting.sql index 90fa9e4b4b8..95a9e19aa1f 100644 --- a/tests/queries/0_stateless/01514_parallel_formatting.sql +++ b/tests/queries/0_stateless/01514_parallel_formatting.sql @@ -1,4 +1,5 @@ drop table if exists tsv; +set output_format_parallel_formatting=1; create table tsv(a int, b int default 7) engine File(TSV); insert into tsv(a) select number from numbers(10000000);