thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 15:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6937 from amosbird/ubmemfix

Browse Source 
In hash tables, properly initialize zero key cell.
This commit is contained in:
akuzm 2019-09-17 14:57:38 +03:00 committed by GitHub
commit 75dc7d331e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dbms/src/Common/HashTable/HashTable.h
View File

@ -224,8 +224,18 @@ private:
public: public:
bool hasZero() const { return has_zero; } bool hasZero() const { return has_zero; }
void setHasZero() { has_zero = true; }
void clearHasZero() { has_zero = false; } void setHasZero()
{
has_zero = true;
new (zeroValue()) Cell();
}
void clearHasZero()
{
has_zero = false;
zeroValue()->~Cell();
}
Cell * zeroValue() { return reinterpret_cast<Cell*>(&zero_value_storage); } Cell * zeroValue() { return reinterpret_cast<Cell*>(&zero_value_storage); }
const Cell * zeroValue() const { return reinterpret_cast<const Cell*>(&zero_value_storage); } const Cell * zeroValue() const { return reinterpret_cast<const Cell*>(&zero_value_storage); }

1
dbms/tests/queries/0_stateless/01011_group_uniq_array_memsan.reference Normal file
View File

@ -0,0 +1 @@
[[],[2]]

1
dbms/tests/queries/0_stateless/01011_group_uniq_array_memsan.sql Normal file
View File

@ -0,0 +1 @@
select groupUniqArray(v) from values('id int, v Array(int)', (1, [2]), (1, [])) group by id;