From 77c963dec5104e2e70ac9a6d955b62067e5ad050 Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@yandex-team.ru>
Date: Mon, 23 Nov 2020 13:32:56 +0300
Subject: [PATCH] Minor changed for ODBC storage

---
 programs/odbc-bridge/ODBCBlockInputStream.cpp | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/programs/odbc-bridge/ODBCBlockInputStream.cpp b/programs/odbc-bridge/ODBCBlockInputStream.cpp
index 00ca89bd887..4cbd60474c9 100644
--- a/programs/odbc-bridge/ODBCBlockInputStream.cpp
+++ b/programs/odbc-bridge/ODBCBlockInputStream.cpp
@@ -79,10 +79,13 @@ namespace
                 assert_cast<ColumnString &>(column).insert(value.convert<String>());
                 break;
             case ValueType::vtDate:
-                assert_cast<ColumnUInt16 &>(column).insertValue(UInt16{LocalDate{value.convert<String>()}.getDayNum()});
+                Poco::DateTime date = value.convert<Poco::DateTime>();
+                assert_cast<ColumnUInt16 &>(column).insertValue(UInt16{LocalDate(date.year(), date.month(), date.day()).getDayNum()});
                 break;
             case ValueType::vtDateTime:
-                assert_cast<ColumnUInt32 &>(column).insertValue(time_t{LocalDateTime{value.convert<String>()}});
+                Poco::DateTime datetime = value.convert<Poco::DateTime>();
+                assert_cast<ColumnUInt32 &>(column).insertValue(time_t{LocalDateTime(
+                    datetime.year(), datetime.month(), datetime.day(), datetime.hour(), datetime.minute(), datetime.second())});
                 break;
             case ValueType::vtUUID:
                 assert_cast<ColumnUInt128 &>(column).insert(parse<UUID>(value.convert<std::string>()));
@@ -112,6 +115,7 @@ Block ODBCBlockInputStream::readImpl()
 
         for (const auto idx : ext::range(0, row.fieldCount()))
         {
+            /// TODO This is extremely slow.
             const Poco::Dynamic::Var & value = row[idx];
 
             if (!value.isEmpty())