thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add retries to flaky tests

Browse Source
This commit is contained in:
János Benjamin Antal 2023-06-26 14:55:03 +00:00
parent fae545ae5c
commit 7cadfeac29
1 changed files with 47 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
tests/integration/test_tlsv1_3/test.py
View File

@ -4,6 +4,7 @@ from helpers.ssl_context import WrapSSLContextWithSNI
import urllib.request, urllib.parse
import ssl
import os.path
import logging
# The test cluster is configured with certificate for that host name, see 'server-ext.cnf'.
@ -11,6 +12,7 @@ import os.path
SSL_HOST = "integration-tests.clickhouse.com"
HTTPS_PORT = 8443
SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
MAX_RETRY = 5
cluster = ClickHouseCluster(__file__)
instance = cluster.add_instance(
@ -88,10 +90,18 @@ def test_https_wrong_cert():
execute_query_https("SELECT currentUser()", user="john", cert_name="client2")
assert "HTTP Error 403" in str(err.value)
count = 0
# Wrong certificate: self-signed certificate.
while count <= MAX_RETRY:
with pytest.raises(Exception) as err:
execute_query_https("SELECT currentUser()", user="john", cert_name="wrong")
assert "unknown ca" in str(err.value)
err_str = str(err.value)
if count < MAX_RETRY and "Broken pipe" in err_str:
count = count + 1
logging.warning(f"Failed attempt with wrong cert, err: {err_str}")
continue
assert "unknown ca" in err_str
break
# No certificate.
with pytest.raises(Exception) as err:
@ -181,7 +191,9 @@ def test_https_non_ssl_auth():
== "jane\n"
)
count = 0
# However if we send a certificate it must not be wrong.
while count <= MAX_RETRY:
with pytest.raises(Exception) as err:
execute_query_https(
"SELECT currentUser()",
@ -189,7 +201,16 @@ def test_https_non_ssl_auth():
enable_ssl_auth=False,
cert_name="wrong",
)
assert "unknown ca" in str(err.value)
err_str = str(err.value)
if count < MAX_RETRY and "Broken pipe" in err_str:
count = count + 1
logging.warning(f"Failed attempt with wrong cert, user: peter, err: {err_str}")
continue
assert "unknown ca" in err_str
break
count = 0
while count <= MAX_RETRY:
with pytest.raises(Exception) as err:
execute_query_https(
"SELECT currentUser()",
@ -198,7 +219,13 @@ def test_https_non_ssl_auth():
password="qwe123",
cert_name="wrong",
)
assert "unknown ca" in str(err.value)
err_str = str(err.value)
if count < MAX_RETRY and "Broken pipe" in err_str:
count = count + 1
logging.warning(f"Failed attempt with wrong cert, user: jane, err: {err_str}")
continue
assert "unknown ca" in err_str
break
def test_create_user():