thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 15:12:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix sharding_key from column w/o function for remote()

Browse Source 
P.S. that code looks redundant, and I'm not even sure that it was
required when it was first added in
325cc47ca5.
This commit is contained in:
Azat Khuzhin 2021-06-29 21:03:39 +03:00
parent 8351f1db99
commit 7e17290acd
3 changed files with 15 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/TableFunctions/TableFunctionRemote.cpp
View File

@ -153,11 +153,6 @@ void TableFunctionRemote::parseArguments(const ASTPtr & ast_function, ContextPtr
if (arg_num < args.size())
throw Exception(help_message, ErrorCodes::NUMBER_OF_ARGUMENTS_DOESNT_MATCH);
/// ExpressionAnalyzer will be created in InterpreterSelectQuery that will meet these `Identifier` when processing the request.
/// We need to mark them as the name of the database or table, because the default value is column.
for (auto ast : args)
setIdentifierSpecial(ast);
if (!cluster_name.empty())
{
/// Use an existing cluster from the main config

0
tests/queries/0_stateless/01932_remote_sharding_key_column.reference Normal file
View File

15
tests/queries/0_stateless/01932_remote_sharding_key_column.sql Normal file
View File

@ -0,0 +1,15 @@
-- regression test for the following query:
--
-- select * from remote('127.1', system.one, dummy)
--
-- that produce the following error before:
--
-- Unknown column: dummy, there are only columns .
--
-- NOTE: that wrapping column into any function works before.
select * from remote('127.1', system.one, dummy) format Null;
select * from remote('127.1', system.one, identity(dummy)) format Null;
select * from remote('127.1', view(select * from system.one), identity(dummy)) format Null;
select * from remote('127.{1,2}', view(select * from system.one), identity(dummy)) format Null;
select * from remote('127.1', view(select * from system.one), dummy) format Null;
select * from remote('127.{1,2}', view(select * from system.one), dummy) format Null;