thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 11:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

do not apply final on distributed engine, only on underlying

Browse Source
This commit is contained in:
Arthur Passos 2022-12-06 17:28:30 -03:00
parent 1cf8dc6daa
commit 7f8a4f8d87
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/Interpreters/InterpreterSelectQuery.cpp
View File

@ -2917,11 +2917,11 @@ void InterpreterSelectQuery::ignoreWithTotals()
bool InterpreterSelectQuery::forceSelectFinalOnSelectQuery(ASTSelectQuery & query) bool InterpreterSelectQuery::forceSelectFinalOnSelectQuery(ASTSelectQuery & query)
{ {
// query.tables() is required because not all queries have tables in it, it could be a function. // query.tables() is required because not all queries have tables in it, it could be a function.
auto isFinalSupported = storage && storage->supportsFinal() && query.tables(); auto is_force_select_final_setting_on = context->getSettingsRef().force_select_final;
auto isForceSelectFinalSettingOn = context->getSettingsRef().force_select_final; auto is_final_supported = storage && storage->supportsFinal() && !storage->isRemote() && query.tables();
auto isQueryAlreadyFinal = query.final(); auto is_query_already_final = query.final();
return isForceSelectFinalSettingOn && !isQueryAlreadyFinal && isFinalSupported; return is_force_select_final_setting_on && !is_query_already_final && is_final_supported;
} }
void InterpreterSelectQuery::initSettings() void InterpreterSelectQuery::initSettings()