thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-28 18:42:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Traverse parts in reverse order

Browse Source
This commit is contained in:
alesapin 2024-11-06 16:30:35 +01:00
parent b1eff04e96
commit 81a6708660
2 changed files with 24 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/Storages/MergeTree/MergeTreeDataMergerMutator.cpp
View File

@ -41,6 +41,7 @@
#include <cmath> #include <cmath>
#include <ctime> #include <ctime>
#include <numeric> #include <numeric>
#include <ranges>
#include <boost/algorithm/string/replace.hpp> #include <boost/algorithm/string/replace.hpp>
@ -370,12 +371,12 @@ MergeTreeDataMergerMutator::MergeSelectingInfo MergeTreeDataMergerMutator::getPo
const String * prev_partition_id = nullptr; const String * prev_partition_id = nullptr;
/// Previous part only in boundaries of partition frame /// Previous part only in boundaries of partition frame
const MergeTreeData::DataPartPtr * prev_part = nullptr; const MergeTreeData::DataPartPtr * next_part = nullptr;
/// collect min_age for each partition while iterating parts /// collect min_age for each partition while iterating parts
PartitionsInfo & partitions_info = res.partitions_info; PartitionsInfo & partitions_info = res.partitions_info;
for (const MergeTreeData::DataPartPtr & part : data_parts) for (const MergeTreeData::DataPartPtr & part : data_parts | std::views::reverse)
{ {
const String & partition_id = part->info.partition_id; const String & partition_id = part->info.partition_id;
@ -386,11 +387,11 @@ MergeTreeDataMergerMutator::MergeSelectingInfo MergeTreeDataMergerMutator::getPo
/// New partition frame. /// New partition frame.
prev_partition_id = &partition_id; prev_partition_id = &partition_id;
prev_part = nullptr; next_part = nullptr;
} }
/// Check predicate only for the first part in each range. /// Check predicate only for the first part in each range.
if (!prev_part) if (!next_part)
{ {
/* Parts can be merged with themselves for TTL needs for example. /* Parts can be merged with themselves for TTL needs for example.
* So we have to check if this part is currently being inserted with quorum and so on and so forth. * So we have to check if this part is currently being inserted with quorum and so on and so forth.
@ -408,10 +409,10 @@ MergeTreeDataMergerMutator::MergeSelectingInfo MergeTreeDataMergerMutator::getPo
{ {
/// If we cannot merge with previous part we had to start new parts /// If we cannot merge with previous part we had to start new parts
/// interval (in the same partition) /// interval (in the same partition)
if (!can_merge_callback(*prev_part, part, txn.get(), out_disable_reason)) if (!can_merge_callback(*next_part, part, txn.get(), out_disable_reason))
{ {
/// Now we have no previous part /// Now we have no previous part
prev_part = nullptr; next_part = nullptr;
/// Mustn't be empty /// Mustn't be empty
assert(!parts_ranges.back().empty()); assert(!parts_ranges.back().empty());
@ -445,18 +446,23 @@ MergeTreeDataMergerMutator::MergeSelectingInfo MergeTreeDataMergerMutator::getPo
parts_ranges.back().emplace_back(part_info); parts_ranges.back().emplace_back(part_info);
/// Check for consistency of data parts. If assertion is failed, it requires immediate investigation. /// Check for consistency of data parts. If assertion is failed, it requires immediate investigation.
if (prev_part) if (next_part)
{ {
if (part->info.contains((*prev_part)->info)) if (part->info.contains((*next_part)->info))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Part {} contains previous part {}", part->name, (*prev_part)->name); throw Exception(ErrorCodes::LOGICAL_ERROR, "Part {} contains previous part {}", part->name, (*next_part)->name);
if (!part->info.isDisjoint((*prev_part)->info)) if (!part->info.isDisjoint((*next_part)->info))
throw Exception(ErrorCodes::LOGICAL_ERROR, "Part {} intersects previous part {}", part->name, (*prev_part)->name); throw Exception(ErrorCodes::LOGICAL_ERROR, "Part {} intersects previous part {}", part->name, (*next_part)->name);
} }
prev_part = &part; next_part = &part;
} }
for (auto & range : res.parts_ranges)
std::reverse(range.begin(), range.end());
std::reverse(res.parts_ranges.begin(), res.parts_ranges.end());
return res; return res;
} }

5
src/Storages/MergeTree/ReplicatedMergeTreeQueue.cpp
View File

@ -2488,7 +2488,12 @@ bool BaseMergePredicate<VirtualPartsT, MutationsStateT>::operator()(
PreformattedMessage & out_reason) const PreformattedMessage & out_reason) const
{ {
if (left) if (left)
{
if (left->info.min_block < right->info.min_block)
return canMergeTwoParts(left, right, out_reason); return canMergeTwoParts(left, right, out_reason);
else
return canMergeTwoParts(right, left, out_reason);
}
return canMergeSinglePart(right, out_reason); return canMergeSinglePart(right, out_reason);
} }