thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 17:12:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant code

Browse Source
This commit is contained in:
Dmitry Novik 2022-06-16 15:49:49 +00:00
parent 376412e417
commit 8479d880f3
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Interpreters/ActionsVisitor.h
View File

@ -1,6 +1,5 @@
#pragma once #pragma once
#include <optional>
#include <string_view> #include <string_view>
#include <Core/NamesAndTypes.h> #include <Core/NamesAndTypes.h>
#include <Interpreters/Context_fwd.h> #include <Interpreters/Context_fwd.h>

6
src/Interpreters/ExpressionAnalyzer.cpp
View File

@ -875,9 +875,6 @@ void ExpressionAnalyzer::makeWindowDescriptions(ActionsDAGPtr actions)
{ {
assert(function_node->is_window_function); assert(function_node->is_window_function);
// Find the window corresponding to this function. It may be either
// referenced by name and previously defined in WINDOW clause, or it
// may be defined inline.
WindowFunctionDescription window_function; WindowFunctionDescription window_function;
window_function.function_node = function_node; window_function.function_node = function_node;
window_function.column_name window_function.column_name
@ -920,6 +917,9 @@ void ExpressionAnalyzer::makeWindowDescriptions(ActionsDAGPtr actions)
window_function.argument_types, window_function.argument_types,
window_function.function_parameters, properties); window_function.function_parameters, properties);
// Find the window corresponding to this function. It may be either
// referenced by name and previously defined in WINDOW clause, or it
// may be defined inline.
if (!function_node->window_name.empty()) if (!function_node->window_name.empty())
{ {
auto it = window_descriptions.find(function_node->window_name); auto it = window_descriptions.find(function_node->window_name);

2
src/Interpreters/WindowDescription.h
View File

@ -95,8 +95,6 @@ struct WindowDescription
// The window functions that are calculated for this window. // The window functions that are calculated for this window.
std::vector<WindowFunctionDescription> window_functions; std::vector<WindowFunctionDescription> window_functions;
// Expressions which use calculated for this window results of window functions.
std::vector<const ASTFunction *> expressions_with_window_functions;
std::string dump() const; std::string dump() const;