add some comments

This commit is contained in:
Anton Popov 2020-05-13 18:53:47 +03:00
parent 67213b8ad4
commit 84d4ad4315
2 changed files with 3 additions and 0 deletions

View File

@ -1022,6 +1022,7 @@ Pipes MergeTreeDataSelectExecutor::spreadMarkRangesAmongStreamsWithOrder(
sort_description.emplace_back(data.sorting_key_columns[j], sort_description.emplace_back(data.sorting_key_columns[j],
input_sorting_info->direction, 1); input_sorting_info->direction, 1);
/// Drop temporary columns, added by 'sorting_key_prefix_expr'
out_projection = createProjection(pipes.back(), data); out_projection = createProjection(pipes.back(), data);
for (auto & pipe : pipes) for (auto & pipe : pipes)
pipe.addSimpleTransform(std::make_shared<ExpressionTransform>(pipe.getHeader(), sorting_key_prefix_expr)); pipe.addSimpleTransform(std::make_shared<ExpressionTransform>(pipe.getHeader(), sorting_key_prefix_expr));
@ -1086,6 +1087,7 @@ Pipes MergeTreeDataSelectExecutor::spreadMarkRangesAmongStreamsFinal(
virt_columns, part.part_index_in_query); virt_columns, part.part_index_in_query);
Pipe pipe(std::move(source_processor)); Pipe pipe(std::move(source_processor));
/// Drop temporary columns, added by 'sorting_key_expr'
if (!out_projection) if (!out_projection)
out_projection = createProjection(pipe, data); out_projection = createProjection(pipe, data);

View File

@ -57,6 +57,7 @@ private:
const Settings & settings, const Settings & settings,
const MergeTreeReaderSettings & reader_settings) const; const MergeTreeReaderSettings & reader_settings) const;
/// out_projection - save projection only with columns, requested to read
Pipes spreadMarkRangesAmongStreamsWithOrder( Pipes spreadMarkRangesAmongStreamsWithOrder(
RangesInDataParts && parts, RangesInDataParts && parts,
size_t num_streams, size_t num_streams,