thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 08:02:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

address some review comments

Browse Source 
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
This commit is contained in:
Duc Canh Le 2024-06-13 01:27:54 +00:00
parent f632424f92
commit 857a412e3b
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Processors/Formats/Impl/BSONEachRowRowInputFormat.cpp
View File

@ -421,7 +421,7 @@ void BSONEachRowRowInputFormat::readTuple(IColumn & column, const DataTypePtr &
"Cannot parse tuple column with type {} from BSON array/embedded document field: "
"tuple doesn't have element with name \"{}\"",
data_type->getName(),
name.toView());
name);
index = *try_get_index;
}
@ -806,7 +806,7 @@ bool BSONEachRowRowInputFormat::readRow(MutableColumns & columns, RowReadExtensi
else
{
if (seen_columns[index])
throw Exception(ErrorCodes::INCORRECT_DATA, "Duplicate field found while parsing BSONEachRow format: {}", name.toView());
throw Exception(ErrorCodes::INCORRECT_DATA, "Duplicate field found while parsing BSONEachRow format: {}", name);
seen_columns[index] = true;
read_columns[index] = readField(*columns[index], types[index], BSONType(type));

4
src/Storages/Kafka/KafkaConsumer.h
View File

@ -1,14 +1,14 @@
#pragma once
#include <cppkafka/topic_partition.h>
#include <fmt/ostream.h>
#include <boost/circular_buffer.hpp>
#include <fmt/ostream.h>
#include <Core/Names.h>
#include <base/types.h>
#include <IO/ReadBuffer.h>
#include <cppkafka/cppkafka.h>
#include <cppkafka/topic_partition.h>
#include <Common/CurrentMetrics.h>
namespace CurrentMetrics