thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 16:50:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Removed extra diagnostic log messages. [#CLICKHOUSE-2902]

Browse Source
This commit is contained in:
Vitaliy Lyudvichenko 2017-04-13 17:43:39 +03:00 committed by alexey-milovidov
parent 848c927bb7
commit 8b54e9fc65
2 changed files with 0 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
dbms/src/Storages/MergeTree/MergeTreeBaseBlockInputStream.cpp
View File

@ -55,36 +55,10 @@ Block MergeTreeBaseBlockInputStream::readImpl()
if (res)
injectVirtualColumns(res);
if (preferred_block_size_bytes && res)
{
size_t block_size_bytes = res.bytes();
max_block_size_bytes = std::max(max_block_size_bytes, block_size_bytes);
sum_block_size_bytes += block_size_bytes;
sum_block_size_rows += res.rows();
++num_blocks;
}
if (task->mark_ranges.empty())
task.reset();
}
if (preferred_block_size_bytes && !res && num_blocks >= 4)
{
size_t avg_bytes = sum_block_size_bytes / num_blocks;
size_t avg_rows = sum_block_size_bytes / num_blocks;
double rel_avg_err = 1. * avg_bytes / preferred_block_size_bytes - 1.;
/// TODO: remove diagnostic after test
if (avg_rows > 8000 && std::abs(rel_avg_err) > 25) // skip uninformative cases
{
LOG_INFO(log, "Read " << num_blocks << " blocks, max_size " << max_block_size_bytes
<< ", avg_bytes " << avg_bytes
<< ", rel_avg_err " << std::fixed << std::setprecision(2) << rel_avg_err * 100 << "%"
<< ", avg_rows " << std::fixed << std::setprecision(2) << avg_rows);
}
}
return res;
}

5
dbms/src/Storages/MergeTree/MergeTreeBaseBlockInputStream.h
View File

@ -72,11 +72,6 @@ protected:
Logger * log;
size_t max_block_size_marks;
size_t num_blocks = 0;
size_t max_block_size_bytes = 0;
size_t sum_block_size_bytes = 0;
size_t sum_block_size_rows = 0;
};
}