thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #18198 from ClickHouse/materialize_mysql_optimize_on_insert

Browse Source 
Enable optimize_on_insert for MaterializeMySQL
This commit is contained in:
tavplubix 2020-12-18 01:50:32 +03:00 committed by GitHub
commit 8bc9d8ed7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Databases/MySQL/MaterializeMySQLSyncThread.cpp
View File

@ -43,7 +43,6 @@ static Context createQueryContext(const Context & global_context)
{
Settings new_query_settings = global_context.getSettings();
new_query_settings.insert_allow_materialized_columns = true;
new_query_settings.optimize_on_insert = false;
Context query_context(global_context);
query_context.setSettings(new_query_settings);

12
tests/integration/test_materialize_mysql_database/materialize_with_ddl.py
View File

@ -478,10 +478,16 @@ def select_without_columns(clickhouse_node, mysql_node, service_name):
clickhouse_node.query("CREATE VIEW v AS SELECT * FROM db.t")
mysql_node.query("INSERT INTO db.t VALUES (1, 1), (2, 2)")
mysql_node.query("DELETE FROM db.t WHERE a=2;")
check_query(clickhouse_node, "SELECT count((_sign, _version)) FROM db.t FORMAT TSV", "3\n")
assert clickhouse_node.query("SELECT count(_sign) FROM db.t FORMAT TSV") == "2\n"
assert clickhouse_node.query("SELECT count(_version) FROM db.t FORMAT TSV") == "2\n"
optimize_on_insert = clickhouse_node.query("SELECT value FROM system.settings WHERE name='optimize_on_insert'").strip()
if optimize_on_insert == "0":
res = ["3\n", "2\n", "2\n"]
else:
res = ["2\n", "2\n", "1\n"]
check_query(clickhouse_node, "SELECT count((_sign, _version)) FROM db.t FORMAT TSV", res[0])
assert clickhouse_node.query("SELECT count(_sign) FROM db.t FORMAT TSV") == res[1]
assert clickhouse_node.query("SELECT count(_version) FROM db.t FORMAT TSV") == res[2]
assert clickhouse_node.query("SELECT count() FROM db.t FORMAT TSV") == "1\n"
assert clickhouse_node.query("SELECT count(*) FROM db.t FORMAT TSV") == "1\n"