From 8c8821475cb25d221780f2fc1bda240278fe860a Mon Sep 17 00:00:00 2001
From: Alexey Milovidov <milovidov@yandex-team.ru>
Date: Sat, 30 May 2020 00:32:35 +0300
Subject: [PATCH] Fix issue #11286; add a test

---
 src/Storages/MergeTree/KeyCondition.cpp       | 10 ++-
 ...01290_empty_array_index_analysis.reference | 50 ++++++++++++++
 .../01290_empty_array_index_analysis.sql      | 66 +++++++++++++++++++
 3 files changed, 124 insertions(+), 2 deletions(-)
 create mode 100644 tests/queries/0_stateless/01290_empty_array_index_analysis.reference
 create mode 100644 tests/queries/0_stateless/01290_empty_array_index_analysis.sql

diff --git a/src/Storages/MergeTree/KeyCondition.cpp b/src/Storages/MergeTree/KeyCondition.cpp
index 6ae22885dfd..ee381709dd4 100644
--- a/src/Storages/MergeTree/KeyCondition.cpp
+++ b/src/Storages/MergeTree/KeyCondition.cpp
@@ -181,8 +181,11 @@ const KeyCondition::AtomMap KeyCondition::atom_map
     },
     {
         "empty",
-        [] (RPNElement & out, const Field &)
+        [] (RPNElement & out, const Field & value)
         {
+            if (value.getType() != Field::Types::String)
+                return false;
+
             out.function = RPNElement::FUNCTION_IN_RANGE;
             out.range = Range("");
             return true;
@@ -190,8 +193,11 @@ const KeyCondition::AtomMap KeyCondition::atom_map
     },
     {
         "notEmpty",
-        [] (RPNElement & out, const Field &)
+        [] (RPNElement & out, const Field & value)
         {
+            if (value.getType() != Field::Types::String)
+                return false;
+
             out.function = RPNElement::FUNCTION_NOT_IN_RANGE;
             out.range = Range("");
             return true;
diff --git a/tests/queries/0_stateless/01290_empty_array_index_analysis.reference b/tests/queries/0_stateless/01290_empty_array_index_analysis.reference
new file mode 100644
index 00000000000..5037a64c0f0
--- /dev/null
+++ b/tests/queries/0_stateless/01290_empty_array_index_analysis.reference
@@ -0,0 +1,50 @@
+--- notEmpty
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- empty
+	[]	1
+--- = []
+	[]	1
+--- != []
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- > []
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- < []
+--- >= []
+	[]	1
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- <= []
+	[]	1
+---
+--- notEmpty
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- empty
+	[]	1
+--- = []
+	[]	1
+--- != []
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- > []
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- < []
+--- >= []
+	[]	1
+	['a']	2
+	['a','b','c']	3
+	['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']	4
+--- <= []
+	[]	1
+---
diff --git a/tests/queries/0_stateless/01290_empty_array_index_analysis.sql b/tests/queries/0_stateless/01290_empty_array_index_analysis.sql
new file mode 100644
index 00000000000..b1b6067945d
--- /dev/null
+++ b/tests/queries/0_stateless/01290_empty_array_index_analysis.sql
@@ -0,0 +1,66 @@
+drop table if exists count_lc_test;
+
+CREATE TABLE count_lc_test
+(
+    `s` LowCardinality(String),
+    `arr` Array(LowCardinality(String)),
+    `num` UInt64
+)
+ENGINE = MergeTree
+ORDER BY (s, arr);
+
+INSERT INTO count_lc_test(num, arr) VALUES (1,[]),(2,['a']),(3,['a','b','c']),(4,['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']);
+
+SELECT '--- notEmpty';
+select * from count_lc_test where notEmpty(arr);
+SELECT '--- empty';
+select * from count_lc_test where empty(arr);
+SELECT '--- = []';
+select * from count_lc_test where arr = [];
+SELECT '--- != []';
+select * from count_lc_test where arr != [];
+SELECT '--- > []';
+select * from count_lc_test where arr > [];
+SELECT '--- < []';
+select * from count_lc_test where arr < [];
+SELECT '--- >= []';
+select * from count_lc_test where arr >= [];
+SELECT '--- <= []';
+select * from count_lc_test where arr <= [];
+SELECT '---';
+
+DROP TABLE count_lc_test;
+
+
+drop table if exists count_lc_test;
+
+CREATE TABLE count_lc_test
+(
+    `s` LowCardinality(String),
+    `arr` Array(String),
+    `num` UInt64
+)
+ENGINE = MergeTree
+ORDER BY (s, arr);
+
+INSERT INTO count_lc_test(num, arr) VALUES (1,[]),(2,['a']),(3,['a','b','c']),(4,['aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa']);
+
+SELECT '--- notEmpty';
+select * from count_lc_test where notEmpty(arr);
+SELECT '--- empty';
+select * from count_lc_test where empty(arr);
+SELECT '--- = []';
+select * from count_lc_test where arr = [];
+SELECT '--- != []';
+select * from count_lc_test where arr != [];
+SELECT '--- > []';
+select * from count_lc_test where arr > [];
+SELECT '--- < []';
+select * from count_lc_test where arr < [];
+SELECT '--- >= []';
+select * from count_lc_test where arr >= [];
+SELECT '--- <= []';
+select * from count_lc_test where arr <= [];
+SELECT '---';
+
+DROP TABLE count_lc_test;