From b319271d59df6544ab356b465ea1a69ade01e7b9 Mon Sep 17 00:00:00 2001 From: Sergei Trifonov Date: Sat, 8 Apr 2023 22:50:24 +0200 Subject: [PATCH] Remove misleading comment It is no longer "significant" after `NOEXCEPT_SCOPE` macro rework #39229 --- .../MergeTree/MergeTreeBackgroundExecutor.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/Storages/MergeTree/MergeTreeBackgroundExecutor.cpp b/src/Storages/MergeTree/MergeTreeBackgroundExecutor.cpp index 65a796456bf..f2efbb2ba8d 100644 --- a/src/Storages/MergeTree/MergeTreeBackgroundExecutor.cpp +++ b/src/Storages/MergeTree/MergeTreeBackgroundExecutor.cpp @@ -217,13 +217,10 @@ void MergeTreeBackgroundExecutor::routine(TaskRuntimeDataPtr item) if (item->is_currently_deleting) { - /// This is significant to order the destructors. - { - NOEXCEPT_SCOPE({ - ALLOW_ALLOCATIONS_IN_SCOPE; - item->task.reset(); - }); - } + NOEXCEPT_SCOPE({ + ALLOW_ALLOCATIONS_IN_SCOPE; + item->task.reset(); + }); item->is_done.set(); item = nullptr; return;