diff --git a/docker/test/performance-comparison/compare.sh b/docker/test/performance-comparison/compare.sh index 55f7b9a310d..725fe215eaa 100755 --- a/docker/test/performance-comparison/compare.sh +++ b/docker/test/performance-comparison/compare.sh @@ -9,40 +9,7 @@ stage=${stage:-} function configure { # Use the new config for both servers, so that we can change it in a PR. - - mkdir right/config/users.d ||: - mkdir right/config/config.d ||: - - # FIXME delete these two configs when the performance.tgz with configs rolls out. - cat > right/config/config.d/zz-perf-test-tweaks-config.xml < - - true - - - - - 0 - - 1000000000 - -EOF - - cat > right/config/users.d/zz-perf-test-tweaks-users.xml < - - - 10000000 - 0 - 1 - 1 - - - -EOF - rm right/config/config.d/text_log.xml ||: - cp -rv right/config left ||: sed -i 's/9000/9001/g' left/config/config.xml @@ -242,7 +209,8 @@ done rm ./*.{rep,svg} test-times.tsv test-dump.tsv unstable.tsv unstable-query-ids.tsv unstable-query-metrics.tsv changed-perf.tsv unstable-tests.tsv unstable-queries.tsv bad-tests.tsv slow-on-client.tsv all-queries.tsv ||: right/clickhouse local --query " -create table queries engine Memory as select +create table queries engine File(TSVWithNamesAndTypes, 'queries.tsv') + as select replaceAll(_file, '-report.tsv', '') test, -- FIXME Comparison mode doesn't make sense for queries that complete @@ -382,7 +350,7 @@ create table stacks engine File(TSV, 'stacks.rep') as join unstable_query_runs using query_id group by query, trace ; -" ||: +" 2>> report-errors.txt ||: IFS=$'\n' for query in $(cut -d' ' -f1 stacks.rep | sort | uniq) diff --git a/docker/test/performance-comparison/config/config.d/perf-comparison-tweaks-config.xml b/docker/test/performance-comparison/config/config.d/perf-comparison-tweaks-config.xml index 5e2ef61252b..3ec87b7dbdc 100644 --- a/docker/test/performance-comparison/config/config.d/perf-comparison-tweaks-config.xml +++ b/docker/test/performance-comparison/config/config.d/perf-comparison-tweaks-config.xml @@ -14,7 +14,6 @@ 1000 - 0 - + 1 1000000000 diff --git a/docker/test/performance-comparison/report.py b/docker/test/performance-comparison/report.py index f48adbb841d..d4fd127008a 100755 --- a/docker/test/performance-comparison/report.py +++ b/docker/test/performance-comparison/report.py @@ -242,6 +242,8 @@ def print_test_times(): print_test_times() +# Add the errors reported by various steps of comparison script +report_errors += tsvRows('report-errors.txt') if len(report_errors): print(tableStart('Errors while building the report')) print(tableHeader(['Error']))