From 9384ab24deb971f655447e9bd8becda2b65a4b47 Mon Sep 17 00:00:00 2001
From: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
Date: Wed, 23 Oct 2024 21:10:37 +0000
Subject: [PATCH] Backport #70979 to 24.9: Fix an error with negative zeros in
 two-level hash table

---
 base/base/StringRef.h                         |  8 +++-
 src/Common/HashTable/HashTable.h              | 39 ++++++++++---------
 ...iq_exact_two_level_negative_zero.reference |  1 +
 ...254_uniq_exact_two_level_negative_zero.sql |  1 +
 4 files changed, 28 insertions(+), 21 deletions(-)
 create mode 100644 tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.reference
 create mode 100644 tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.sql

diff --git a/base/base/StringRef.h b/base/base/StringRef.h
index fc0674b8440..062aae5c0da 100644
--- a/base/base/StringRef.h
+++ b/base/base/StringRef.h
@@ -369,11 +369,15 @@ namespace PackedZeroTraits
 {
     template <typename Second, template <typename, typename> class PackedPairNoInit>
     inline bool check(const PackedPairNoInit<StringRef, Second> p)
-    { return 0 == p.key.size; }
+    {
+        return 0 == p.key.size;
+    }
 
     template <typename Second, template <typename, typename> class PackedPairNoInit>
     inline void set(PackedPairNoInit<StringRef, Second> & p)
-    { p.key.size = 0; }
+    {
+        p.key.size = 0;
+    }
 }
 
 
diff --git a/src/Common/HashTable/HashTable.h b/src/Common/HashTable/HashTable.h
index a600f57b06a..07a61d5865d 100644
--- a/src/Common/HashTable/HashTable.h
+++ b/src/Common/HashTable/HashTable.h
@@ -67,19 +67,6 @@ struct HashTableNoState
 };
 
 
-/// These functions can be overloaded for custom types.
-namespace ZeroTraits
-{
-
-template <typename T>
-bool check(const T x) { return x == T{}; }
-
-template <typename T>
-void set(T & x) { x = T{}; }
-
-}
-
-
 /** Numbers are compared bitwise.
   * Complex types are compared by operator== as usual (this is important if there are gaps).
   *
@@ -87,18 +74,32 @@ void set(T & x) { x = T{}; }
   * Otherwise the invariants in hash table probing do not met when NaNs are present.
   */
 template <typename T>
-inline bool bitEquals(T && a, T && b)
+inline bool bitEquals(T a, T b)
 {
-    using RealT = std::decay_t<T>;
-
-    if constexpr (std::is_floating_point_v<RealT>)
-        /// Note that memcmp with constant size is compiler builtin.
-        return 0 == memcmp(&a, &b, sizeof(RealT)); /// NOLINT
+    if constexpr (std::is_floating_point_v<T>)
+        /// Note that memcmp with constant size is a compiler builtin.
+        return 0 == memcmp(&a, &b, sizeof(T)); /// NOLINT
     else
         return a == b;
 }
 
 
+/// These functions can be overloaded for custom types.
+namespace ZeroTraits
+{
+
+template <typename T>
+bool check(const T x)
+{
+    return bitEquals(x, T{});
+}
+
+template <typename T>
+void set(T & x) { x = T{}; }
+
+}
+
+
 /**
   * getKey/Mapped -- methods to get key/"mapped" values from the LookupResult returned by find() and
   * emplace() methods of HashTable. Must not be called for a null LookupResult.
diff --git a/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.reference b/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.reference
new file mode 100644
index 00000000000..771c05369c1
--- /dev/null
+++ b/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.reference
@@ -0,0 +1 @@
+7992019
diff --git a/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.sql b/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.sql
new file mode 100644
index 00000000000..3237818d290
--- /dev/null
+++ b/tests/queries/0_stateless/03254_uniq_exact_two_level_negative_zero.sql
@@ -0,0 +1 @@
+WITH number % 1000 = 0 ? (rand() % 2 ? 0.0 : -0.0) : number::Float64 AS x SELECT length(uniqExactState(x)::String) FROM numbers(1000000);