From 96317da8d227a4ead19d713d1edd74f8a20ef609 Mon Sep 17 00:00:00 2001 From: shiyer7474 Date: Tue, 24 Sep 2024 05:19:21 +0000 Subject: [PATCH] Review feedback --- src/Functions/getSetting.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/Functions/getSetting.cpp b/src/Functions/getSetting.cpp index 1b09a3b01cf..aced1583ed3 100644 --- a/src/Functions/getSetting.cpp +++ b/src/Functions/getSetting.cpp @@ -83,15 +83,10 @@ private: throw; else if (error_handling == ErrorHandling::Default) { - if (arguments.size() == 2) - { - auto default_value_column = arguments[1].column; + auto default_value_column = arguments[1].column; - setting_value = (*default_value_column)[0]; - } + setting_value = (*default_value_column)[0]; } - else - setting_value = Field(Null()); } return setting_value; }