thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-10-05 08:00:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixed the UB loop

Browse Source
This commit is contained in:
myrrc 2020-11-10 19:48:32 +03:00
parent c80e05f18e
commit 96598dcbb8
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
base/common/wide_integer_impl.h
View File

@ -261,15 +261,16 @@ struct integer<Bits, Signed>::_impl
const long double rhs_max_int_count = rhs_long_double / max_int;
// Won't fit only if long double can hold values >= 2^(64 * 3).
const uint64_t rhs_max_int_count_max_int_count = rhs_max_int_count / max_int;
// We can't just get the number of iterations like rhs_max_int_count / max_int as it may not fit it int64_t.
long double rhs_max_int_count_acc = rhs_max_int_count;
self = 0;
for (uint64_t i = 0; i < rhs_max_int_count_max_int_count; ++i)
while (rhs_max_int_count_acc > max_int_long_double)
{
self += max_int;
rhs_max_int_count_acc -= max_int_long_double;
}
self *= max_int;