thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-27 01:51:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review fixes

Browse Source
This commit is contained in:
kssenii 2023-12-11 12:42:23 +01:00
parent a06179da00
commit 966a09fb70
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/Storages/PostgreSQL/MaterializedPostgreSQLConsumer.cpp
View File

@ -549,7 +549,7 @@ void MaterializedPostgreSQLConsumer::processReplicationMessage(const char * repl
return;
}
auto log_table_structure_changed = [&](std::string_view reason)
auto log_table_structure_changed = [&](const std::string & reason)
{
LOG_INFO(log, "Table structure of the table {} changed ({}), "
"will mark it as skipped from replication. "

2
src/Storages/PostgreSQL/PostgreSQLReplicationHandler.cpp
View File

@ -447,8 +447,6 @@ StorageInfo PostgreSQLReplicationHandler::loadFromSnapshot(postgres::Connection
assertBlocksHaveEqualStructure(input->getPort().getHeader(), block_io.pipeline.getHeader(), "postgresql replica load from snapshot");
block_io.pipeline.complete(Pipe(std::move(input)));
/// TODO: make a test when we fail in the middle of inserting data from source.
CompletedPipelineExecutor executor(block_io.pipeline);
executor.execute();

2
src/Storages/PostgreSQL/StorageMaterializedPostgreSQL.cpp
View File

@ -198,7 +198,7 @@ void StorageMaterializedPostgreSQL::createNestedIfNeeded(PostgreSQLTableStructur
auto table_id = getStorageID();
auto tmp_nested_table_id = StorageID(table_id.database_name, getNestedTableName());
LOG_DEBUG(log, "Creating clickhouse table for postgresql table {} (ast: {})",
table_id.getNameForLogs(), serializeAST(*ast_create));
table_id.getNameForLogs(), ast_create->formatForLogging());
InterpreterCreateQuery interpreter(ast_create, nested_context);
interpreter.execute();