thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add negative tests.

Browse Source 
Also:
- Add comments in tests.
- Add an example in docs where an IPv4 is casted to an int, byteswapped
  and then casted back to an IPv4.
This commit is contained in:
Priyansh Agrawal 2023-10-09 21:50:23 +00:00
parent 2e4709fd10
commit 9677dedd87
4 changed files with 42 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/en/sql-reference/functions/math-functions.md
View File

@ -741,11 +741,7 @@ Note that, in step#1, one can also choose to convert the operand to bytes in lit
One use-case of this function is reversing IPv4s:
```result
┌─toIPv4(3351772109)─┐
│ 199.199.251.205 │
└────────────────────┘
┌─toIPv4(byteSwap(3351772109))─┐
│ 205.251.199.199 │
└──────────────────────────────┘
```
┌─toIPv4(byteSwap(toUInt32(toIPv4('205.251.199.199'))))─┐
│ 199.199.251.205 │
└───────────────────────────────────────────────────────┘
```

10
src/Functions/byteSwap.cpp
View File

@ -82,13 +82,9 @@ Note that, in step#1, one can also choose to convert the operand to bytes in lit
One use-case of this function is reversing IPv4s:
```result
┌─toIPv4(3351772109)─┐
│ 199.199.251.205 │
└────────────────────┘
┌─toIPv4(byteSwap(3351772109))─┐
│ 205.251.199.199 │
└──────────────────────────────┘
┌─toIPv4(byteSwap(toUInt32(toIPv4('205.251.199.199'))))─┐
│ 199.199.251.205 │
└───────────────────────────────────────────────────────┘
```
)",
.examples{

2
tests/queries/0_stateless/02887_byteswap.reference
View File

@ -25,3 +25,5 @@
-549755813889
4039370097989451775
128
0
1

34
tests/queries/0_stateless/02887_byteswap.sql
View File

@ -1,34 +1,66 @@
/* UInt8 */
SELECT byteSwap(0);
SELECT byteSwap(1);
SELECT byteSwap(255);
/* UInt16 */
SELECT byteSwap(256);
SELECT byteSwap(4135);
SELECT byteSwap(10000);
SELECT byteSwap(65535);
/* UInt32 */
SELECT byteSwap(65536);
SELECT byteSwap(3351772109);
SELECT byteSwap(3455829959);
SELECT byteSwap(4294967295);
/* UInt64 */
SELECT byteSwap(4294967296);
SELECT byteSwap(123294967295);
SELECT byteSwap(18439412204227788800);
SELECT byteSwap(18446744073709551615);
/* Int8 */
SELECT byteSwap(-0);
SELECT byteSwap(-1);
SELECT byteSwap(-128);
/* Int16 */
SELECT byteSwap(-129);
SELECT byteSwap(-4135);
SELECT byteSwap(-32768);
/* Int32 */
SELECT byteSwap(-32769);
SELECT byteSwap(-3351772109);
SELECT byteSwap(-2147483648);
/* Int64 */
SELECT byteSwap(-2147483649);
SELECT byteSwap(-1242525266376);
SELECT byteswap(-9223372036854775808);
SELECT byteSwap(-9223372036854775808);
/* Booleans are interpreted as UInt8 */
SELECT byteSwap(false);
SELECT byteSwap(true);
/* Integer overflows */
SELECT byteSwap(18446744073709551616); -- { serverError 48 }
SELECT byteSwap(-9223372036854775809); -- { serverError 48 }
/* Number of arguments should equal 1 */
SELECT byteSwap(); -- { serverError 42 }
SELECT byteSwap(128, 129); -- { serverError 42 }
/* Input should be "integral" */
SELECT byteSwap('abc'); -- { serverError 43 }
SELECT byteSwap(reinterpretAsFixedString(3351772109)); -- { serverError 43 }
SELECT byteSwap(toDate('2019-01-01')); -- { serverError 43 }
SELECT byteSwap(toDate32('2019-01-01')); -- { serverError 43 }
SELECT byteSwap(toDateTime32(1546300800)); -- { serverError 43 }
SELECT byteSwap(toDateTime64(1546300800, 3)); -- { serverError 43 }
SELECT byteSwap(generateUUIDv4()); -- { serverError 43 }
SELECT byteSwap(toDecimal32(2, 4)); -- { serverError 43 }
SELECT byteSwap(toFloat32(123.456)); -- { serverError 48 }
SELECT byteSwap(toFloat64(123.456)); -- { serverError 48 }