Merge pull request #72346 from ClickHouse/add_final

Add some random final modifier to some classes
This commit is contained in:
alesapin 2024-11-23 22:48:34 +00:00 committed by GitHub
commit 96bba07d9c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 7 deletions

View File

@ -51,7 +51,7 @@ namespace
} }
/// Reads chunks from file in native format. Provide chunks with aggregation info. /// Reads chunks from file in native format. Provide chunks with aggregation info.
class SourceFromNativeStream : public ISource class SourceFromNativeStream final : public ISource
{ {
public: public:
explicit SourceFromNativeStream(const Block & header, TemporaryBlockStreamReaderHolder tmp_stream_) explicit SourceFromNativeStream(const Block & header, TemporaryBlockStreamReaderHolder tmp_stream_)
@ -84,7 +84,7 @@ namespace
/// Worker which merges buckets for two-level aggregation. /// Worker which merges buckets for two-level aggregation.
/// Atomically increments bucket counter and returns merged result. /// Atomically increments bucket counter and returns merged result.
class ConvertingAggregatedToChunksWithMergingSource : public ISource class ConvertingAggregatedToChunksWithMergingSource final : public ISource
{ {
public: public:
static constexpr UInt32 NUM_BUCKETS = 256; static constexpr UInt32 NUM_BUCKETS = 256;
@ -143,7 +143,7 @@ private:
}; };
/// Asks Aggregator to convert accumulated aggregation state into blocks (without merging) and pushes them to later steps. /// Asks Aggregator to convert accumulated aggregation state into blocks (without merging) and pushes them to later steps.
class ConvertingAggregatedToChunksSource : public ISource class ConvertingAggregatedToChunksSource final : public ISource
{ {
public: public:
ConvertingAggregatedToChunksSource(AggregatingTransformParamsPtr params_, AggregatedDataVariantsPtr variant_) ConvertingAggregatedToChunksSource(AggregatingTransformParamsPtr params_, AggregatedDataVariantsPtr variant_)
@ -188,7 +188,7 @@ private:
}; };
/// Reads chunks from GroupingAggregatedTransform (stored in ChunksToMerge structure) and outputs them. /// Reads chunks from GroupingAggregatedTransform (stored in ChunksToMerge structure) and outputs them.
class FlattenChunksToMergeTransform : public IProcessor class FlattenChunksToMergeTransform final : public IProcessor
{ {
public: public:
explicit FlattenChunksToMergeTransform(const Block & input_header, const Block & output_header) explicit FlattenChunksToMergeTransform(const Block & input_header, const Block & output_header)
@ -272,7 +272,7 @@ private:
/// ConvertingAggregatedToChunksWithMergingSource -> /// ConvertingAggregatedToChunksWithMergingSource ->
/// ///
/// Result chunks guaranteed to be sorted by bucket number. /// Result chunks guaranteed to be sorted by bucket number.
class ConvertingAggregatedToChunksTransform : public IProcessor class ConvertingAggregatedToChunksTransform final : public IProcessor
{ {
public: public:
ConvertingAggregatedToChunksTransform(AggregatingTransformParamsPtr params_, ManyAggregatedDataVariantsPtr data_, size_t num_threads_) ConvertingAggregatedToChunksTransform(AggregatingTransformParamsPtr params_, ManyAggregatedDataVariantsPtr data_, size_t num_threads_)

View File

@ -22,7 +22,7 @@ namespace CurrentMetrics
namespace DB namespace DB
{ {
class AggregatedChunkInfo : public ChunkInfoCloneable<AggregatedChunkInfo> class AggregatedChunkInfo final : public ChunkInfoCloneable<AggregatedChunkInfo>
{ {
public: public:
bool is_overflows = false; bool is_overflows = false;
@ -149,7 +149,7 @@ using ManyAggregatedDataPtr = std::shared_ptr<ManyAggregatedData>;
* At aggregation step, every transform uses it's own AggregatedDataVariants structure. * At aggregation step, every transform uses it's own AggregatedDataVariants structure.
* At merging step, all structures pass to ConvertingAggregatedToChunksTransform. * At merging step, all structures pass to ConvertingAggregatedToChunksTransform.
*/ */
class AggregatingTransform : public IProcessor class AggregatingTransform final : public IProcessor
{ {
public: public:
AggregatingTransform(Block header, AggregatingTransformParamsPtr params_); AggregatingTransform(Block header, AggregatingTransformParamsPtr params_);