From 98e5ea52062048a00c8a1cc9e53c376717b88e72 Mon Sep 17 00:00:00 2001 From: Arthur Passos Date: Fri, 14 Jun 2024 10:02:40 -0300 Subject: [PATCH] style fix --- src/Access/Authentication.cpp | 3 ++- src/Interpreters/SessionLog.cpp | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Access/Authentication.cpp b/src/Access/Authentication.cpp index 166230c52eb..80153f415a0 100644 --- a/src/Access/Authentication.cpp +++ b/src/Access/Authentication.cpp @@ -16,7 +16,7 @@ namespace DB namespace ErrorCodes { extern const int NOT_IMPLEMENTED; - extern const int SUPPORT_IS_DISABLED; + extern const int LOGICAL_ERROR; } namespace @@ -256,6 +256,7 @@ bool Authentication::areCredentialsValid( // below code sucks, but works for now I guess. + // might be a problem if no auth method has been registered std::string possible_authentication_types; bool first = true; diff --git a/src/Interpreters/SessionLog.cpp b/src/Interpreters/SessionLog.cpp index 51fc83f515f..903eaff499f 100644 --- a/src/Interpreters/SessionLog.cpp +++ b/src/Interpreters/SessionLog.cpp @@ -207,6 +207,7 @@ void SessionLogElement::appendToBlock(MutableColumns & columns) const columns[i++]->insertData(auth_failure_reason.data(), auth_failure_reason.length()); } +// todo arthur fix this method void SessionLog::addLoginSuccess(const UUID & auth_id, const String & session_id, const Settings & settings,