Merge pull request #36817 from DevTeamBK/Clang-tidy-Fixes

Clang -Tidy Fixes

src/Client/LocalConnection.cpp

@@ -410,7 +410,7 @@ Packet LocalConnection::receivePacket()
         {
             if (state->profile_info)
             {
-                packet.profile_info = std::move(*state->profile_info);
+                packet.profile_info = *state->profile_info;
                 state->profile_info.reset();
             }
             next_packet_type.reset();

src/Common/FileCache.h

@@ -170,9 +170,9 @@ private:
 
         FileSegmentCell(FileSegmentPtr file_segment_, LRUQueue & queue_);
 
-        FileSegmentCell(FileSegmentCell && other)
+        FileSegmentCell(FileSegmentCell && other) noexcept
             : file_segment(std::move(other.file_segment))
-            , queue_iterator(std::move(other.queue_iterator)) {}
+            , queue_iterator(other.queue_iterator) {}
 
         std::pair<Key, size_t> getKeyAndOffset() const { return std::make_pair(file_segment->key(), file_segment->range().left); }
     };

src/Common/FileSegment.h

@@ -229,7 +229,7 @@ private:
 struct FileSegmentsHolder : private boost::noncopyable
 {
     explicit FileSegmentsHolder(FileSegments && file_segments_) : file_segments(std::move(file_segments_)) {}
-    FileSegmentsHolder(FileSegmentsHolder && other) : file_segments(std::move(other.file_segments)) {}
+    FileSegmentsHolder(FileSegmentsHolder && other) noexcept : file_segments(std::move(other.file_segments)) {}
 
     ~FileSegmentsHolder();
 

src/Disks/S3/registerDiskS3.cpp

@@ -161,7 +161,7 @@ std::unique_ptr<DiskS3Settings> getSettings(const Poco::Util::AbstractConfigurat
 
     return std::make_unique<DiskS3Settings>(
         getClient(config, config_prefix, context),
-        std::move(rw_settings),
+        rw_settings,
         config.getUInt64(config_prefix + ".min_bytes_for_seek", 1024 * 1024),
         config.getBool(config_prefix + ".send_metadata", false),
         config.getInt(config_prefix + ".thread_pool_size", 16),

src/QueryPipeline/BlockIO.cpp

@@ -37,7 +37,7 @@ BlockIO & BlockIO::operator= (BlockIO && rhs) noexcept
     finish_callback         = std::move(rhs.finish_callback);
     exception_callback      = std::move(rhs.exception_callback);
 
-    null_format             = std::move(rhs.null_format);
+    null_format             = rhs.null_format;
 
     return *this;
 }