Remove unnecessary warning suppressions #10396

2024-11-21 15:12:02 +00:00 · 2020-05-09 23:30:28 +03:00 · 2020-05-09 23:30:28 +03:00 · 99ceb12b19
commit 99ceb12b19
parent e41e998f4a
15 changed files with 25 additions and 27 deletions
--- a/contrib/jemalloc-cmake/CMakeLists.txt
+++ b/contrib/jemalloc-cmake/CMakeLists.txt
@ -69,7 +69,7 @@ if (ENABLE_JEMALLOC)
            endif ()
        endif ()

-        target_compile_options(jemalloc PUBLIC -Wno-redundant-decls)
+        target_compile_options(jemalloc PRIVATE -Wno-redundant-decls)
    else ()
        find_library(LIBRARY_JEMALLOC jemalloc)
        find_path(INCLUDE_JEMALLOC jemalloc/jemalloc.h)
--- a/contrib/libcpuid-cmake/CMakeLists.txt
+++ b/contrib/libcpuid-cmake/CMakeLists.txt
@ -20,11 +20,11 @@ if (ENABLE_CPUID)

    add_library (cpuid ${SRCS})

-    target_include_directories (cpuid PUBLIC ${LIBRARY_DIR})
+    target_include_directories (cpuid SYSTEM PUBLIC ${LIBRARY_DIR})
    target_compile_definitions (cpuid PUBLIC USE_CPUID=1)
    target_compile_definitions (cpuid PRIVATE VERSION="v0.4.1")
    if (COMPILER_CLANG)
-        target_compile_options (cpuid PUBLIC -Wno-reserved-id-macro)
+        target_compile_options (cpuid PRIVATE -Wno-reserved-id-macro)
    endif ()

    message (STATUS "Using cpuid")
--- a/contrib/poco-cmake/Crypto/CMakeLists.txt
+++ b/contrib/poco-cmake/Crypto/CMakeLists.txt
@ -28,8 +28,8 @@ if (ENABLE_SSL)
        add_library (_poco_crypto ${SRCS})
        add_library (Poco::Crypto ALIAS _poco_crypto)

-        target_compile_options (_poco_crypto PUBLIC -Wno-newline-eof)
-        target_include_directories (_poco_crypto PUBLIC ${LIBRARY_DIR}/Crypto/include)
+        target_compile_options (_poco_crypto PRIVATE -Wno-newline-eof)
+        target_include_directories (_poco_crypto SYSTEM PUBLIC ${LIBRARY_DIR}/Crypto/include)
        target_link_libraries (_poco_crypto PUBLIC Poco::Foundation ssl)
    else ()
        add_library (Poco::Crypto UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/Data/CMakeLists.txt
+++ b/contrib/poco-cmake/Data/CMakeLists.txt
@ -41,9 +41,9 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (Poco::Data ALIAS _poco_data)

    if (COMPILER_GCC)
-        target_compile_options (_poco_data PUBLIC -Wno-deprecated-copy)
+        target_compile_options (_poco_data PRIVATE -Wno-deprecated-copy)
    endif ()
-    target_include_directories (_poco_data PUBLIC ${LIBRARY_DIR}/Data/include)
+    target_include_directories (_poco_data SYSTEM PUBLIC ${LIBRARY_DIR}/Data/include)
    target_link_libraries (_poco_data PUBLIC Poco::Foundation)
 else ()
    # NOTE: don't know why, but the GLOBAL is required here.
--- a/contrib/poco-cmake/Data/ODBC/CMakeLists.txt
+++ b/contrib/poco-cmake/Data/ODBC/CMakeLists.txt
@ -20,8 +20,8 @@ if (ENABLE_ODBC)
        add_library (_poco_data_odbc ${SRCS})
        add_library (Poco::Data::ODBC ALIAS _poco_data_odbc)

-        target_compile_options (_poco_data_odbc PUBLIC -Wno-unused-variable)
-        target_include_directories (_poco_data_odbc PUBLIC ${LIBRARY_DIR}/Data/ODBC/include)
+        target_compile_options (_poco_data_odbc PRIVATE -Wno-unused-variable)
+        target_include_directories (_poco_data_odbc SYSTEM PUBLIC ${LIBRARY_DIR}/Data/ODBC/include)
        target_link_libraries (_poco_data_odbc PUBLIC Poco::Data unixodbc)
    else ()
        add_library (Poco::Data::ODBC UNKNOWN IMPORTED)
--- a/contrib/poco-cmake/Foundation/CMakeLists.txt
+++ b/contrib/poco-cmake/Foundation/CMakeLists.txt
@ -193,12 +193,12 @@ if (USE_INTERNAL_POCO_LIBRARY)

    if (COMPILER_GCC)
        target_compile_options (_poco_foundation
-            PUBLIC
+            PRIVATE
                -Wno-suggest-override
        )
    elseif (COMPILER_CLANG)
        target_compile_options (_poco_foundation
-            PUBLIC
+            PRIVATE
                -Wno-atomic-implicit-seq-cst
                -Wno-deprecated
                -Wno-extra-semi-stmt
@ -209,7 +209,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
        )
    endif ()
    target_compile_options (_poco_foundation
-        PUBLIC
+        PRIVATE
            -Wno-sign-compare
            -Wno-unused-parameter
    )
@ -221,7 +221,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
            POCO_ENABLE_CPP11
            POCO_OS_FAMILY_UNIX
    )
-    target_include_directories (_poco_foundation PUBLIC ${LIBRARY_DIR}/Foundation/include)
+    target_include_directories (_poco_foundation SYSTEM PUBLIC ${LIBRARY_DIR}/Foundation/include)
    target_link_libraries (_poco_foundation PRIVATE Poco::Foundation::PCRE zlib)
 else ()
    add_library (Poco::Foundation UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/JSON/CMakeLists.txt
+++ b/contrib/poco-cmake/JSON/CMakeLists.txt
@ -28,7 +28,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (_poco_json ${SRCS})
    add_library (Poco::JSON ALIAS _poco_json)

-    target_include_directories (_poco_json PUBLIC ${LIBRARY_DIR}/JSON/include)
+    target_include_directories (_poco_json SYSTEM PUBLIC ${LIBRARY_DIR}/JSON/include)
    target_link_libraries (_poco_json PUBLIC Poco::Foundation Poco::JSON::Pdjson)
 else ()
    add_library (Poco::JSON UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/MongoDB/CMakeLists.txt
+++ b/contrib/poco-cmake/MongoDB/CMakeLists.txt
@ -26,7 +26,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (_poco_mongodb ${SRCS})
    add_library (Poco::MongoDB ALIAS _poco_mongodb)

-    target_include_directories (_poco_mongodb PUBLIC ${LIBRARY_DIR}/MongoDB/include)
+    target_include_directories (_poco_mongodb SYSTEM PUBLIC ${LIBRARY_DIR}/MongoDB/include)
    target_link_libraries (_poco_mongodb PUBLIC Poco::Net)
 else ()
    add_library (Poco::MongoDB UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/Net/CMakeLists.txt
+++ b/contrib/poco-cmake/Net/CMakeLists.txt
@ -117,7 +117,6 @@ if (USE_INTERNAL_POCO_LIBRARY)
            PRIVATE
                -Wno-atomic-implicit-seq-cst
                -Wno-extra-semi-stmt
-            PUBLIC
                -Wno-extra-semi
        )
    endif ()
@ -126,7 +125,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
            -Wno-deprecated
            -Wno-extra-semi
    )
-    target_include_directories (_poco_net PUBLIC ${LIBRARY_DIR}/Net/include)
+    target_include_directories (_poco_net SYSTEM PUBLIC ${LIBRARY_DIR}/Net/include)
    target_link_libraries (_poco_net PUBLIC Poco::Foundation)
 else ()
    add_library (Poco::Net UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/Net/SSL/CMakeLists.txt
+++ b/contrib/poco-cmake/Net/SSL/CMakeLists.txt
@ -33,7 +33,7 @@ if (ENABLE_SSL)
        add_library (_poco_net_ssl ${SRCS})
        add_library (Poco::Net::SSL ALIAS _poco_net_ssl)

-        target_include_directories (_poco_net_ssl PUBLIC ${LIBRARY_DIR}/NetSSL_OpenSSL/include)
+        target_include_directories (_poco_net_ssl SYSTEM PUBLIC ${LIBRARY_DIR}/NetSSL_OpenSSL/include)
        target_link_libraries (_poco_net_ssl PUBLIC Poco::Crypto Poco::Net Poco::Util)
    else ()
        add_library (Poco::Net::SSL UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/Redis/CMakeLists.txt
+++ b/contrib/poco-cmake/Redis/CMakeLists.txt
@ -15,10 +15,10 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (Poco::Redis ALIAS _poco_redis)

    if (COMPILER_GCC)
-        target_compile_options (_poco_redis PUBLIC -Wno-deprecated-copy)
+        target_compile_options (_poco_redis PRIVATE -Wno-deprecated-copy)
    endif ()
-    target_compile_options (_poco_redis PUBLIC -Wno-shadow)
-    target_include_directories (_poco_redis PUBLIC ${LIBRARY_DIR}/Redis/include)
+    target_compile_options (_poco_redis PRIVATE -Wno-shadow)
+    target_include_directories (_poco_redis SYSTEM PUBLIC ${LIBRARY_DIR}/Redis/include)
    target_link_libraries (_poco_redis PUBLIC Poco::Net)
 else ()
    add_library (Poco::Redis UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/Util/CMakeLists.txt
+++ b/contrib/poco-cmake/Util/CMakeLists.txt
@ -32,7 +32,7 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (_poco_util ${SRCS})
    add_library (Poco::Util ALIAS _poco_util)

-    target_include_directories (_poco_util PUBLIC ${LIBRARY_DIR}/Util/include)
+    target_include_directories (_poco_util SYSTEM PUBLIC ${LIBRARY_DIR}/Util/include)
    target_link_libraries (_poco_util PUBLIC Poco::JSON Poco::XML)
 else ()
    add_library (Poco::Util UNKNOWN IMPORTED GLOBAL)
--- a/contrib/poco-cmake/XML/CMakeLists.txt
+++ b/contrib/poco-cmake/XML/CMakeLists.txt
@ -95,8 +95,8 @@ if (USE_INTERNAL_POCO_LIBRARY)
    add_library (_poco_xml ${SRCS})
    add_library (Poco::XML ALIAS _poco_xml)

-    target_compile_options (_poco_xml PUBLIC -Wno-old-style-cast)
-    target_include_directories (_poco_xml PUBLIC ${LIBRARY_DIR}/XML/include)
+    target_compile_options (_poco_xml PRIVATE -Wno-old-style-cast)
+    target_include_directories (_poco_xml SYSTEM PUBLIC ${LIBRARY_DIR}/XML/include)
    target_link_libraries (_poco_xml PUBLIC Poco::Foundation Poco::XML::Expat)
 else ()
    add_library (Poco::XML UNKNOWN IMPORTED GLOBAL)
--- a/contrib/replxx-cmake/CMakeLists.txt
+++ b/contrib/replxx-cmake/CMakeLists.txt
@ -46,7 +46,7 @@ if (ENABLE_REPLXX)
    endif ()

    if (COMPILER_CLANG)
-        target_compile_options(replxx PUBLIC -Wno-documentation)
+        target_compile_options(replxx PRIVATE -Wno-documentation)
    endif ()

    target_compile_definitions(replxx PUBLIC USE_REPLXX=1)
--- a/contrib/unixodbc-cmake/CMakeLists.txt
+++ b/contrib/unixodbc-cmake/CMakeLists.txt
@ -295,9 +295,8 @@ if (ENABLE_ODBC)
                -Wno-parentheses
                -Wno-misleading-indentation
                -Wno-unknown-warning-option
-                -O2
-            PUBLIC
                -Wno-reserved-id-macro
+                -O2
        )
    else ()
        add_library (unixodbc UNKNOWN IMPORTED)