thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-18 04:12:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert fix result type of aggregate function with NULL

Browse Source
This commit is contained in:
vdimir 2023-11-27 17:54:24 +00:00
parent 1f474a870a
commit 9a793bcd03
No known key found for this signature in database
GPG Key ID: 6EE4CE2BEDC51862
1 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/Analyzer/Passes/QueryAnalysisPass.cpp
View File

@ -5185,24 +5185,7 @@ ProjectionNames QueryAnalyzer::resolveFunction(QueryTreeNodePtr & node, Identifi
AggregateFunctionProperties properties; AggregateFunctionProperties properties;
auto aggregate_function = AggregateFunctionFactory::instance().get(aggregate_function_name, argument_types, parameters, properties); auto aggregate_function = AggregateFunctionFactory::instance().get(aggregate_function_name, argument_types, parameters, properties);
if (aggregate_function->getName() == "nothing")
{
/** When we resolve aggregate function into `nothing` it may have different result type.
* For functions with peorperty `returns_default_when_only_null` set to true, it will be UInt64, for other functions it will be Null.
* Aggregate function `nothing` returns the same type as first argument has.
* In that case we may need to set first argument to correct type.
* Also we don't want to replace first argument, but just prepend it because it may have aliases, for example
* SELECT count(NULL AS a), sum(a) FROM table
*/
const auto & actual_result_type = aggregate_function->getResultType();
if (!argument_types.empty() && !argument_types.front()->equals(*actual_result_type))
{
QueryTreeNodes & nodes = function_node.getArguments().getNodes();
QueryTreeNodes new_nodes = {std::make_shared<ConstantNode>(actual_result_type->getDefault(), actual_result_type)};
std::move(nodes.begin(), nodes.end(), std::back_inserter(new_nodes));
nodes = std::move(new_nodes);
}
}
function_node.resolveAsAggregateFunction(std::move(aggregate_function)); function_node.resolveAsAggregateFunction(std::move(aggregate_function));
return result_projection_names; return result_projection_names;