thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Analyzer join_use_nulls fix

Browse Source
This commit is contained in:
Maksim Kita 2023-02-05 14:30:04 +01:00
parent 0cba5848ac
commit 9b7cd64093
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Analyzer/Passes/QueryAnalysisPass.cpp
View File

@ -2960,14 +2960,21 @@ QueryTreeNodePtr QueryAnalyzer::tryResolveIdentifierFromJoin(const IdentifierLoo
bool join_use_nulls = scope.context->getSettingsRef().join_use_nulls;
if (join_use_nulls
&& (isFull(join_kind) ||
(isLeft(join_kind) && resolved_side && *resolved_side == JoinTableSide::Right) ||
(isRight(join_kind) && resolved_side && *resolved_side == JoinTableSide::Left)))
if (join_use_nulls &&
resolved_identifier->getNodeType() == QueryTreeNodeType::COLUMN &&
(isFull(join_kind) ||
(isLeft(join_kind) && resolved_side && *resolved_side == JoinTableSide::Right) ||
(isRight(join_kind) && resolved_side && *resolved_side == JoinTableSide::Left)))
{
resolved_identifier = resolved_identifier->clone();
auto & resolved_column = resolved_identifier->as<ColumnNode &>();
resolved_column.setColumnType(makeNullable(resolved_column.getColumnType()));
const auto & resolved_column_type = resolved_column.getColumnType();
const auto & resolved_column_name = resolved_column.getColumnName();
auto to_nullable_function_resolver = FunctionFactory::instance().get("toNullable", scope.context);
auto to_nullable_function_arguments = {ColumnWithTypeAndName(nullptr, resolved_column_type, resolved_column_name)};
auto to_nullable_function = to_nullable_function_resolver->build(to_nullable_function_arguments);
resolved_column.setColumnType(to_nullable_function->getResultType());
}
return resolved_identifier;