fix clang build

This commit is contained in:
BohuTANG 2020-04-29 11:26:33 +08:00 committed by zhang2014
parent c899c34f03
commit 9c2ecf008c
2 changed files with 11 additions and 13 deletions

View File

@ -80,18 +80,17 @@ void MySQLFlavor::readPayloadImpl(ReadBuffer & payload)
switch (event_header.type)
{
case FORMAT_DESCRIPTION_EVENT: {
event = std::make_shared<FormatDescriptionEvent>(FormatDescriptionEvent());
event = std::make_shared<FormatDescriptionEvent>();
event->parse(payload);
break;
}
case ROTATE_EVENT: {
event = std::make_shared<RotateEvent>(RotateEvent());
event = std::make_shared<RotateEvent>();
event->parse(payload);
break;
}
default:
throw ReplicationError("Unsupported event: " + event_header.type, ErrorCodes::UNEXPECTED_PACKET_FROM_SERVER);
break;
throw ReplicationError("Unsupported event: " + std::to_string(event_header.type), ErrorCodes::UNEXPECTED_PACKET_FROM_SERVER);
}
}

View File

@ -9,7 +9,6 @@
namespace DB
{
namespace MySQLReplication
{
using namespace MySQLProtocol;
@ -84,7 +83,7 @@ namespace MySQLReplication
virtual void dump() = 0;
};
class EventHeader : public IBinlogEvent
class EventHeader
{
public:
UInt32 timestamp;
@ -97,8 +96,8 @@ namespace MySQLReplication
EventHeader() = default;
~EventHeader() = default;
void parse(ReadBuffer & payload) override ;
void dump() override ;
void parse(ReadBuffer & payload);
void dump() ;
};
class FormatDescriptionEvent : public IBinlogEvent
@ -111,11 +110,11 @@ namespace MySQLReplication
String event_type_header_length;
FormatDescriptionEvent() = default;
~FormatDescriptionEvent() = default;
~FormatDescriptionEvent() override = default;
EventType type() override { return FORMAT_DESCRIPTION_EVENT; }
void parse(ReadBuffer & payload) override;
void dump() override ;
void dump() override;
};
class RotateEvent : public IBinlogEvent
@ -125,11 +124,11 @@ namespace MySQLReplication
String next_binlog;
RotateEvent() = default;
~RotateEvent() = default;
~RotateEvent() override = default;
EventType type() override { return ROTATE_EVENT; }
void parse(ReadBuffer & payload) override;
void dump() override ;
void dump() override;
};
class IFlavor
@ -146,7 +145,7 @@ namespace MySQLReplication
BinlogEventPtr event;
MySQLFlavor() = default;
~MySQLFlavor() = default;
~MySQLFlavor() override = default;
String getName() override { return "MySQL"; }
void readPayloadImpl(ReadBuffer & payload) override;