Improve utility zookeeper-adjust-block-numbers-to-parts.

Add filter on shards and tables.
Add flag --dry-run.
The utility now checks cversion before doing anything.
This commit is contained in:
Vitaly Baranov 2019-07-19 03:39:22 +03:00
parent a01fa50a93
commit 9fb3135c23
2 changed files with 158 additions and 46 deletions

View File

@ -24,6 +24,7 @@ if (NOT DEFINED ENABLE_UTILS OR ENABLE_UTILS)
add_subdirectory (zookeeper-copy-tree)
add_subdirectory (zookeeper-remove-by-list)
add_subdirectory (zookeeper-create-entry-to-download-part)
add_subdirectory (zookeeper-adjust-block-numbers-to-parts)
add_subdirectory (wikistat-loader)
add_subdirectory (fill-factor)
add_subdirectory (check-marks)

View File

@ -1,13 +1,55 @@
#include <Storages/MergeTree/ReplicatedMergeTreeTableMetadata.h>
#include <Storages/MergeTree/MergeTreePartInfo.h>
#include <Common/ZooKeeper/ZooKeeper.h>
#include <boost/algorithm/string.hpp>
#include <boost/program_options.hpp>
#include <IO/ReadHelpers.h>
#include <unordered_map>
#include <cmath>
size_t getMaxBlockSizeForPartition(zkutil::ZooKeeper & zk,
std::vector<std::string> getAllShards(zkutil::ZooKeeper & zk, const std::string & root)
{
return zk.getChildren(root);
}
std::vector<std::string> removeNotExistingShards(zkutil::ZooKeeper & zk, const std::string & root, const std::vector<std::string> & shards)
{
auto existing_shards = getAllShards(zk, root);
std::vector<std::string> filtered_shards;
filtered_shards.reserve(shards.size());
for (const auto & shard : shards)
if (std::find(existing_shards.begin(), existing_shards.end(), shard) == existing_shards.end())
std::cerr << "Shard " << shard << " not found." << std::endl;
else
filtered_shards.emplace_back(shard);
return filtered_shards;
}
std::vector<std::string> getAllTables(zkutil::ZooKeeper & zk, const std::string & root, const std::string & shard)
{
return zk.getChildren(root + "/" + shard);
}
std::vector<std::string> removeNotExistingTables(zkutil::ZooKeeper & zk, const std::string & root, const std::string & shard, const std::vector<std::string> & tables)
{
auto existing_tables = getAllTables(zk, root, shard);
std::vector<std::string> filtered_tables;
filtered_tables.reserve(tables.size());
for (const auto & table : tables)
if (std::find(existing_tables.begin(), existing_tables.end(), table) == existing_tables.end())
std::cerr << "\tTable " << table << " not found on shard " << shard << "." << std::endl;
else
filtered_tables.emplace_back(table);
return filtered_tables;
}
size_t getMaxBlockNumberForPartition(zkutil::ZooKeeper & zk,
const std::string & replica_path,
const std::string & partition_name,
const DB::MergeTreeDataFormatVersion & format_version)
@ -28,36 +70,74 @@ size_t getMaxBlockSizeForPartition(zkutil::ZooKeeper & zk,
}
catch (const DB::Exception & ex)
{
std::cerr << "Exception on: " << ex.displayText() << " will skip part: " << part << std::endl;
std::cerr << ex.displayText() << ", Part " << part << "skipped." << std::endl;
}
}
}
return max_block_num;
}
std::unordered_map<std::string, size_t> getAllTablesBlockPaths(zkutil::ZooKeeper & zk, const std::string & root)
size_t getCurrentBlockNumberForPartition(zkutil::ZooKeeper & zk, const std::string & part_path)
{
Coordination::Stat stat;
zk.get(part_path, &stat);
/// References:
/// https://stackoverflow.com/a/10347910
/// https://bowenli86.github.io/2016/07/07/distributed%20system/zookeeper/How-does-ZooKeeper-s-persistent-sequential-id-work/
return (stat.cversion + stat.numChildren) / 2;
}
std::unordered_map<std::string, size_t> getPartitionsNeedAdjustingBlockNumbers(
zkutil::ZooKeeper & zk, const std::string & root, const std::vector<std::string> & shards, const std::vector<std::string> & tables)
{
std::unordered_map<std::string, size_t> result;
auto shards = zk.getChildren(root);
for (const auto & shard : shards)
std::vector<std::string> use_shards = shards.empty() ? getAllShards(zk, root) : removeNotExistingShards(zk, root, shards);
for (const auto & shard : use_shards)
{
std::string shard_path = root + "/" + shard;
auto tables = zk.getChildren(shard_path);
for (auto table : tables)
std::cout << "Shard: " << shard << std::endl;
std::vector<std::string> use_tables = tables.empty() ? getAllTables(zk, root, shard) : removeNotExistingTables(zk, root, shard, tables);
for (auto table : use_tables)
{
std::cerr << "Searching for nodes in: " << table << std::endl;
std::string table_path = shard_path + "/" + table;
auto format_version = DB::ReplicatedMergeTreeTableMetadata::parse(zk.get(table_path + "/metadata")).data_format_version;
std::cout << "\tTable: " << table << std::endl;
std::string table_path = root + "/" + shard + "/" + table;
std::string blocks_path = table_path + "/block_numbers";
auto partitions = zk.getChildren(blocks_path);
if (!partitions.empty())
std::vector<std::string> partitions;
DB::MergeTreeDataFormatVersion format_version;
try
{
for (auto partition : partitions)
format_version = DB::ReplicatedMergeTreeTableMetadata::parse(zk.get(table_path + "/metadata")).data_format_version;
partitions = zk.getChildren(blocks_path);
}
catch (const DB::Exception & ex)
{
std::cerr << ex.displayText() << ", table " << table << " skipped." << std::endl;
continue;
}
for (auto partition : partitions)
{
try
{
std::string part_path = blocks_path + "/" + partition;
size_t partition_max_block = getMaxBlockSizeForPartition(zk, table_path, partition, format_version);
std::cerr << "\tFound max block number: " << partition_max_block << " for part: " << partition << std::endl;
result.emplace(part_path, partition_max_block);
size_t partition_max_block = getMaxBlockNumberForPartition(zk, table_path, partition, format_version);
size_t current_block_number = getCurrentBlockNumberForPartition(zk, part_path);
if (current_block_number <= partition_max_block)
{
std::cout << "\t\tPartition: " << partition << ": current block_number: " << current_block_number
<< ", max block number: " << partition_max_block << ". Adjusting is required." << std::endl;
result.emplace(part_path, partition_max_block);
}
}
catch (const DB::Exception & ex)
{
std::cerr << ex.displayText() << ", partition " << partition << " skipped." << std::endl;
}
}
}
@ -66,67 +146,98 @@ std::unordered_map<std::string, size_t> getAllTablesBlockPaths(zkutil::ZooKeeper
}
void rotateNodes(zkutil::ZooKeeper & zk, const std::string & path, size_t max_block_num)
void setCurrentBlockNumber(zkutil::ZooKeeper & zk, const std::string & path, size_t new_current_block_number)
{
Coordination::Requests requests;
std::string block_prefix = path + "/block-";
std::string current = zk.create(block_prefix, "", zkutil::CreateMode::EphemeralSequential);
size_t current_block_num = DB::parse<UInt64>(current.c_str() + block_prefix.size(), current.size() - block_prefix.size());
if (current_block_num >= max_block_num)
{
std::cerr << "Nothing to rotate, current block num: " << current_block_num << " max_block_num:" << max_block_num << std::endl;
return;
}
Coordination::Requests requests;
size_t need_to_rotate = max_block_num - current_block_num;
std::cerr << "Will rotate: " << need_to_rotate << " block numbers from " << current_block_num << " to " << max_block_num << std::endl;
for (size_t i = 0; i < need_to_rotate; ++i)
for (size_t current_block_number = getCurrentBlockNumberForPartition(zk, path);
current_block_number < new_current_block_number;
++current_block_number)
{
if (requests.size() == 50)
{
std::cerr << "Rotating: " << i << " block numbers" << std::endl;
zk.multi(requests);
std::cout << path << ": " << requests.size() << " ephemeral sequential nodes inserted." << std::endl;
requests.clear();
}
requests.emplace_back(zkutil::makeCreateRequest(path + "/block-", "", zkutil::CreateMode::EphemeralSequential));
}
if (!requests.empty())
{
std::cout << path << ": " << requests.size() << " ephemeral sequential nodes inserted." << std::endl;
zk.multi(requests);
}
}
int main(int argc, char ** argv)
try
{
boost::program_options::options_description desc("Allowed options");
/// Parse the command line.
namespace po = boost::program_options;
po::options_description desc("Allowed options");
desc.add_options()
("help,h", "produce help message")
("address,a", boost::program_options::value<std::string>()->required(), "addresses of ZooKeeper instances, comma separated. Example: example01e.yandex.ru:2181")
("path,p", boost::program_options::value<std::string>()->required(), "path of replica queue to insert node (without trailing slash)");
("help,h", "show help")
("zookeeper,z", po::value<std::string>(), "Addresses of ZooKeeper instances, comma-separated. Example: example01e.yandex.ru:2181")
("path,p", po::value<std::string>(), "[optional] Path of replica queue to insert node (without trailing slash). By default it's /clickhouse/tables")
("shard,s", po::value<std::string>(), "[optional] Shards to process, comma-separated. If not specified then the utility will process all the shards.")
("table,t", po::value<std::string>(), "[optional] Tables to process, comma-separated. If not specified then the utility will process all the tables.")
("dry-run", "[optional] Specify if you want this utility just to analyze block numbers without any changes.");
boost::program_options::variables_map options;
boost::program_options::store(boost::program_options::parse_command_line(argc, argv, desc), options);
po::variables_map options;
po::store(po::parse_command_line(argc, argv, desc), options);
if (options.count("help"))
auto show_usage = [&]
{
std::cout << "Util for /block_numbers node adjust with max block number in partition" << std::endl;
std::cout << "Usage: " << argv[0] << " [options]" << std::endl;
std::cout << "Usage: " << std::endl;
std::cout << " " << argv[0] << " [options]" << std::endl;
std::cout << desc << std::endl;
};
if (options.count("help") || (argc == 1))
{
std::cout << "This utility adjusts the /block_numbers zookeeper nodes to the correct block number in partition." << std::endl;
std::cout << "It might be useful when incorrect block numbers stored in zookeeper don't allow you to insert data into a table or drop/detach a partition." << std::endl;
show_usage();
return 0;
}
if (!options.count("zookeeper"))
{
std::cerr << "Option --zookeeper should be set." << std::endl;
show_usage();
return 1;
}
std::string global_path = options.at("path").as<std::string>();
std::string root = options.count("path") ? options.at("path").as<std::string>() : "/clickhouse/tables";
zkutil::ZooKeeper zookeeper(options.at("address").as<std::string>());
std::vector<std::string> shards, tables;
if (options.count("shard"))
boost::split(shards, options.at("shard").as<std::string>(), boost::algorithm::is_any_of(","));
if (options.count("table"))
boost::split(tables, options.at("table").as<std::string>(), boost::algorithm::is_any_of(","));
auto all_path = getAllTablesBlockPaths(zookeeper, global_path);
for (const auto & [path, max_block_num] : all_path)
/// Check if the adjusting of the block numbers is required.
std::cout << "Checking if adjusting of the block numbers is required:" << std::endl;
zkutil::ZooKeeper zookeeper(options.at("zookeeper").as<std::string>());
auto part_paths_with_max_block_numbers = getPartitionsNeedAdjustingBlockNumbers(zookeeper, root, shards, tables);
if (part_paths_with_max_block_numbers.empty())
{
std::cerr << "Rotating on: " << path << std::endl;
rotateNodes(zookeeper, path, max_block_num);
std::cout << "No adjusting required." << std::endl;
return 0;
}
/// Adjust the block numbers.
if (options.count("dry-run"))
return 0;
std::cout << std::endl << "Adjusting the block numbers:" << std::endl;
for (const auto & [part_path, max_block_number] : part_paths_with_max_block_numbers)
setCurrentBlockNumber(zookeeper, part_path, max_block_number + 1);
return 0;
}
catch (const Poco::Exception & e)