thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-22 23:52:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #60160 from rschu1ze/bool-cast

Browse Source 
Allow casting of bools in string representation to to true bools
This commit is contained in:
Robert Schulze 2024-02-20 17:19:02 +01:00 committed by GitHub
commit a1a45ed881
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Interpreters/convertFieldToType.cpp
View File

@ -493,10 +493,12 @@ Field convertFieldToTypeImpl(const Field & src, const IDataType & type, const ID
{ {
/// Promote data type to avoid overflows. Note that overflows in the largest data type are still possible. /// Promote data type to avoid overflows. Note that overflows in the largest data type are still possible.
/// But don't promote Float32, since we want to keep the exact same value /// But don't promote Float32, since we want to keep the exact same value
/// Also don't promote domain types (like bool) because we would otherwise use the serializer of the promoted type (e.g. UInt64 for
/// bool, which does not allow 'true' and 'false' as input values)
const IDataType * type_to_parse = &type; const IDataType * type_to_parse = &type;
DataTypePtr holder; DataTypePtr holder;
if (type.canBePromoted() && !which_type.isFloat32()) if (type.canBePromoted() && !which_type.isFloat32() && !type.getCustomSerialization())
{ {
holder = type.promoteNumericType(); holder = type.promoteNumericType();
type_to_parse = holder.get(); type_to_parse = holder.get();

1
tests/queries/0_stateless/02933_compare_with_bool_as_string.reference Normal file
View File

@ -0,0 +1 @@
1

1
tests/queries/0_stateless/02933_compare_with_bool_as_string.sql Normal file
View File

@ -0,0 +1 @@
select true = 'true';