thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-30 19:42:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #59162 from ClickHouse/fix-url-encoded-diff

Browse Source 
Fix url encoding issue
This commit is contained in:
robot-ch-test-poll4 2024-01-24 14:46:54 +01:00 committed by GitHub
commit a4da999c9d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/ci/pr_info.py
View File

@ -3,15 +3,20 @@ import json
import logging
import os
from typing import Dict, List, Set, Union
from urllib.parse import quote
# isort: off
# for some reason this line moves to the end
from unidiff import PatchSet # type: ignore
# isort: on
from build_download_helper import get_gh_api
from env_helper import (
GITHUB_REPOSITORY,
GITHUB_SERVER_URL,
GITHUB_RUN_URL,
GITHUB_EVENT_PATH,
GITHUB_REPOSITORY,
GITHUB_RUN_URL,
GITHUB_SERVER_URL,
)
FORCE_TESTS_LABEL = "force tests"
@ -295,9 +300,10 @@ class PRInfo:
@staticmethod
def compare_url(first: str, second: str) -> str:
"""the first and second are URL encoded to not fail on '#' and other symbols"""
return (
"https://api.github.com/repos/"
f"{GITHUB_REPOSITORY}/compare/{first}...{second}"
f"{GITHUB_REPOSITORY}/compare/{quote(first)}...{quote(second)}"
)
def fetch_changed_files(self):