From e4689ce302524e73477bff25370a2da67034b4ef Mon Sep 17 00:00:00 2001 From: Nikolai Kochetov Date: Tue, 21 Jul 2020 16:58:07 +0300 Subject: [PATCH] Make IFunction::executeImpl const. --- src/Functions/FunctionBase64Conversion.h | 2 +- src/Functions/FunctionBinaryArithmetic.h | 6 +- src/Functions/FunctionBitTestMany.h | 10 +- src/Functions/FunctionCustomWeekToSomething.h | 2 +- .../FunctionDateOrDateTimeAddInterval.h | 2 +- .../FunctionDateOrDateTimeToSomething.h | 2 +- src/Functions/FunctionFQDN.cpp | 2 +- src/Functions/FunctionMathBinaryFloat64.h | 6 +- src/Functions/FunctionMathConstFloat64.h | 2 +- src/Functions/FunctionMathUnary.h | 2 +- src/Functions/FunctionNumericPredicate.h | 4 +- src/Functions/FunctionStartsEndsWith.h | 4 +- src/Functions/FunctionStringOrArrayToT.h | 2 +- src/Functions/FunctionStringReplace.h | 2 +- src/Functions/FunctionStringToString.h | 2 +- src/Functions/FunctionUnaryArithmetic.h | 2 +- src/Functions/FunctionUnixTimestamp64.h | 2 +- src/Functions/FunctionsBitmap.h | 26 ++-- src/Functions/FunctionsCoding.h | 62 ++++---- src/Functions/FunctionsComparison.h | 26 ++-- src/Functions/FunctionsConsistentHashing.h | 8 +- src/Functions/FunctionsConversion.h | 6 +- src/Functions/FunctionsEmbeddedDictionaries.h | 8 +- src/Functions/FunctionsExternalDictionaries.h | 58 +++---- src/Functions/FunctionsExternalModels.cpp | 2 +- src/Functions/FunctionsExternalModels.h | 2 +- src/Functions/FunctionsFormatting.h | 8 +- src/Functions/FunctionsHashing.h | 26 ++-- src/Functions/FunctionsJSON.h | 2 +- src/Functions/FunctionsLogical.cpp | 4 +- src/Functions/FunctionsLogical.h | 4 +- .../FunctionsMultiStringFuzzySearch.h | 2 +- src/Functions/FunctionsMultiStringPosition.h | 2 +- src/Functions/FunctionsMultiStringSearch.h | 2 +- src/Functions/FunctionsRandom.h | 4 +- src/Functions/FunctionsRound.h | 10 +- src/Functions/FunctionsStringArray.h | 6 +- src/Functions/FunctionsStringSearch.h | 2 +- src/Functions/FunctionsStringSearchToString.h | 2 +- src/Functions/FunctionsStringSimilarity.h | 2 +- src/Functions/GatherUtils/GatherUtils.h | 2 +- src/Functions/GatherUtils/has.cpp | 4 +- src/Functions/IFunctionImpl.h | 4 +- src/Functions/LeastGreatestGeneric.h | 2 +- src/Functions/PerformanceAdaptors.h | 4 +- src/Functions/URL/port.cpp | 2 +- src/Functions/addressToLine.cpp | 31 ++-- src/Functions/addressToSymbol.cpp | 2 +- src/Functions/appendTrailingCharIfAbsent.cpp | 2 +- src/Functions/array/FunctionArrayMapped.h | 2 +- src/Functions/array/array.cpp | 2 +- src/Functions/array/arrayConcat.cpp | 2 +- src/Functions/array/arrayDistinct.cpp | 4 +- src/Functions/array/arrayElement.cpp | 16 +- src/Functions/array/arrayEnumerate.cpp | 2 +- src/Functions/array/arrayEnumerateExtended.h | 32 ++-- src/Functions/array/arrayEnumerateRanked.h | 8 +- src/Functions/array/arrayFlatten.cpp | 2 +- src/Functions/array/arrayIndex.h | 14 +- src/Functions/array/arrayIntersect.cpp | 4 +- src/Functions/array/arrayJoin.cpp | 2 +- src/Functions/array/arrayPop.h | 2 +- src/Functions/array/arrayPush.h | 2 +- src/Functions/array/arrayReduce.cpp | 4 +- src/Functions/array/arrayReduceInRanges.cpp | 4 +- src/Functions/array/arrayResize.cpp | 2 +- src/Functions/array/arrayReverse.cpp | 4 +- src/Functions/array/arrayScalarProduct.h | 6 +- src/Functions/array/arraySlice.cpp | 2 +- src/Functions/array/arrayUniq.cpp | 32 ++-- src/Functions/array/arrayWithConstant.cpp | 2 +- src/Functions/array/arrayZip.cpp | 2 +- src/Functions/array/emptyArray.cpp | 2 +- src/Functions/array/emptyArrayToSingle.cpp | 4 +- src/Functions/array/hasAllAny.h | 2 +- src/Functions/array/range.cpp | 12 +- src/Functions/assumeNotNull.cpp | 2 +- src/Functions/bar.cpp | 2 +- src/Functions/blockNumber.cpp | 4 +- src/Functions/blockSerializedSize.cpp | 2 +- src/Functions/blockSize.cpp | 2 +- src/Functions/buildId.cpp | 2 +- src/Functions/caseWithExpression.cpp | 2 +- src/Functions/coalesce.cpp | 2 +- src/Functions/concat.cpp | 6 +- src/Functions/convertCharset.cpp | 2 +- src/Functions/currentDatabase.cpp | 2 +- src/Functions/currentUser.cpp | 2 +- src/Functions/dateDiff.cpp | 16 +- src/Functions/defaultValueOfArgumentType.cpp | 2 +- src/Functions/demange.cpp | 2 +- src/Functions/dumpColumnStructure.cpp | 2 +- src/Functions/equals.cpp | 2 +- src/Functions/evalMLMethod.cpp | 2 +- src/Functions/extractAllGroups.h | 2 +- src/Functions/extractGroups.cpp | 2 +- src/Functions/filesystem.cpp | 8 +- src/Functions/finalizeAggregation.cpp | 2 +- src/Functions/formatDateTime.cpp | 4 +- src/Functions/formatString.cpp | 2 +- src/Functions/fuzzBits.cpp | 2 +- src/Functions/generateUUIDv4.cpp | 4 +- src/Functions/geoToH3.cpp | 2 +- src/Functions/geohashDecode.cpp | 4 +- src/Functions/geohashEncode.cpp | 4 +- src/Functions/geohashesInBox.cpp | 4 +- src/Functions/getMacro.cpp | 2 +- src/Functions/getScalar.cpp | 2 +- src/Functions/getSizeOfEnumType.cpp | 2 +- src/Functions/globalVariable.cpp | 2 +- src/Functions/greatCircleDistance.cpp | 4 +- src/Functions/greater.cpp | 2 +- src/Functions/greaterOrEquals.cpp | 2 +- src/Functions/h3EdgeAngle.cpp | 2 +- src/Functions/h3EdgeLengthM.cpp | 2 +- src/Functions/h3GetBaseCell.cpp | 2 +- src/Functions/h3GetResolution.cpp | 2 +- src/Functions/h3HexAreaM2.cpp | 2 +- src/Functions/h3IndexesAreNeighbors.cpp | 2 +- src/Functions/h3IsValid.cpp | 2 +- src/Functions/h3ToChildren.cpp | 2 +- src/Functions/h3ToParent.cpp | 2 +- src/Functions/h3ToString.cpp | 2 +- src/Functions/h3kRing.cpp | 2 +- src/Functions/hasColumnInTable.cpp | 4 +- src/Functions/hasThreadFuzzer.cpp | 2 +- src/Functions/hostName.cpp | 2 +- src/Functions/identity.cpp | 2 +- src/Functions/if.cpp | 18 +-- src/Functions/ifNotFinite.cpp | 2 +- src/Functions/ifNull.cpp | 2 +- src/Functions/ignore.cpp | 2 +- src/Functions/in.cpp | 2 +- src/Functions/initializeAggregation.cpp | 4 +- src/Functions/isConstant.cpp | 2 +- src/Functions/isNotNull.cpp | 2 +- src/Functions/isNull.cpp | 2 +- src/Functions/isZeroOrNull.cpp | 6 +- src/Functions/less.cpp | 2 +- src/Functions/lessOrEquals.cpp | 2 +- src/Functions/lowCardinalityIndices.cpp | 2 +- src/Functions/lowCardinalityKeys.cpp | 2 +- src/Functions/materialize.cpp | 2 +- src/Functions/multiIf.cpp | 2 +- src/Functions/neighbor.cpp | 2 +- src/Functions/notEquals.cpp | 2 +- src/Functions/now64.cpp | 2 +- src/Functions/nullIf.cpp | 2 +- src/Functions/pointInEllipses.cpp | 2 +- src/Functions/pointInPolygon.cpp | 2 +- src/Functions/randomFixedString.cpp | 4 +- src/Functions/randomPrintableASCII.cpp | 2 +- src/Functions/randomString.cpp | 4 +- src/Functions/randomStringUTF8.cpp | 2 +- src/Functions/regexpQuoteMeta.cpp | 2 +- src/Functions/reinterpretAsFixedString.cpp | 2 +- src/Functions/reinterpretAsString.cpp | 2 +- src/Functions/reinterpretStringAs.cpp | 2 +- src/Functions/repeat.cpp | 2 +- src/Functions/replicate.cpp | 2 +- src/Functions/reverse.cpp | 2 +- src/Functions/rowNumberInAllBlocks.cpp | 6 +- src/Functions/rowNumberInBlock.cpp | 2 +- src/Functions/runningAccumulate.cpp | 2 +- src/Functions/runningDifference.h | 2 +- src/Functions/sleep.h | 2 +- src/Functions/stringToH3.cpp | 2 +- src/Functions/substring.cpp | 4 +- src/Functions/throwIf.cpp | 4 +- src/Functions/timeSlots.cpp | 2 +- src/Functions/timezone.cpp | 2 +- src/Functions/toColumnTypeName.cpp | 2 +- src/Functions/toFixedString.h | 2 +- src/Functions/toLowCardinality.cpp | 2 +- src/Functions/toNullable.cpp | 2 +- src/Functions/toStartOfInterval.cpp | 8 +- src/Functions/toTimeZone.cpp | 2 +- src/Functions/transform.cpp | 143 +++++++++--------- src/Functions/trap.cpp | 2 +- src/Functions/tuple.cpp | 2 +- src/Functions/tupleElement.cpp | 2 +- src/Functions/uptime.cpp | 2 +- src/Functions/version.cpp | 2 +- src/Functions/visibleWidth.cpp | 2 +- 184 files changed, 500 insertions(+), 490 deletions(-) diff --git a/src/Functions/FunctionBase64Conversion.h b/src/Functions/FunctionBase64Conversion.h index 5b100bf68ce..450bad496cd 100644 --- a/src/Functions/FunctionBase64Conversion.h +++ b/src/Functions/FunctionBase64Conversion.h @@ -89,7 +89,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const ColumnPtr column_string = block.getByPosition(arguments[0]).column; const ColumnString * input = checkAndGetColumn(column_string.get()); diff --git a/src/Functions/FunctionBinaryArithmetic.h b/src/Functions/FunctionBinaryArithmetic.h index dbead7bff01..7a38ac1bef8 100644 --- a/src/Functions/FunctionBinaryArithmetic.h +++ b/src/Functions/FunctionBinaryArithmetic.h @@ -862,7 +862,7 @@ public: return type_res; } - bool executeFixedString(Block & block, const ColumnNumbers & arguments, size_t result) + bool executeFixedString(Block & block, const ColumnNumbers & arguments, size_t result) const { using OpImpl = FixedStringOperationImpl>; @@ -940,7 +940,7 @@ public: } template - bool executeNumeric(Block & block, const ColumnNumbers & arguments, size_t result [[maybe_unused]], const A & left, const B & right) + bool executeNumeric(Block & block, const ColumnNumbers & arguments, size_t result [[maybe_unused]], const A & left, const B & right) const { using LeftDataType = std::decay_t; using RightDataType = std::decay_t; @@ -1073,7 +1073,7 @@ public: return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { /// Special case when multiply aggregate function state if (isAggregateMultiply(block.getByPosition(arguments[0]).type, block.getByPosition(arguments[1]).type)) diff --git a/src/Functions/FunctionBitTestMany.h b/src/Functions/FunctionBitTestMany.h index ea8f5e1bd7c..ae2b4df422c 100644 --- a/src/Functions/FunctionBitTestMany.h +++ b/src/Functions/FunctionBitTestMany.h @@ -54,7 +54,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block , const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block , const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto value_col = block.getByPosition(arguments.front()).column.get(); @@ -73,7 +73,7 @@ private: template bool execute( Block & block, const ColumnNumbers & arguments, const size_t result, - const IColumn * const value_col_untyped) + const IColumn * const value_col_untyped) const { if (const auto value_col = checkAndGetColumn>(value_col_untyped)) { @@ -132,7 +132,7 @@ private: } template - ValueType createConstMaskIfConst(const Block & block, const ColumnNumbers & arguments, bool & out_is_const) + ValueType createConstMaskIfConst(const Block & block, const ColumnNumbers & arguments, bool & out_is_const) const { out_is_const = true; ValueType mask = 0; @@ -156,7 +156,7 @@ private: } template - PaddedPODArray createMask(const size_t size, const Block & block, const ColumnNumbers & arguments) + PaddedPODArray createMask(const size_t size, const Block & block, const ColumnNumbers & arguments) const { PaddedPODArray mask(size, ValueType{}); @@ -175,7 +175,7 @@ private: } template - bool NO_SANITIZE_UNDEFINED addToMaskImpl(PaddedPODArray & mask, const IColumn * const pos_col_untyped) + bool NO_SANITIZE_UNDEFINED addToMaskImpl(PaddedPODArray & mask, const IColumn * const pos_col_untyped) const { if (const auto pos_col = checkAndGetColumn>(pos_col_untyped)) { diff --git a/src/Functions/FunctionCustomWeekToSomething.h b/src/Functions/FunctionCustomWeekToSomething.h index 5dda225032d..3daed746386 100644 --- a/src/Functions/FunctionCustomWeekToSomething.h +++ b/src/Functions/FunctionCustomWeekToSomething.h @@ -95,7 +95,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1, 2}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); WhichDataType which(from_type); diff --git a/src/Functions/FunctionDateOrDateTimeAddInterval.h b/src/Functions/FunctionDateOrDateTimeAddInterval.h index eaed159c17b..61b8075efc6 100644 --- a/src/Functions/FunctionDateOrDateTimeAddInterval.h +++ b/src/Functions/FunctionDateOrDateTimeAddInterval.h @@ -462,7 +462,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {2}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); WhichDataType which(from_type); diff --git a/src/Functions/FunctionDateOrDateTimeToSomething.h b/src/Functions/FunctionDateOrDateTimeToSomething.h index 85fb89ea4c1..c635ede0e45 100644 --- a/src/Functions/FunctionDateOrDateTimeToSomething.h +++ b/src/Functions/FunctionDateOrDateTimeToSomething.h @@ -84,7 +84,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); WhichDataType which(from_type); diff --git a/src/Functions/FunctionFQDN.cpp b/src/Functions/FunctionFQDN.cpp index 12be3508e40..b8bf0fe131a 100644 --- a/src/Functions/FunctionFQDN.cpp +++ b/src/Functions/FunctionFQDN.cpp @@ -34,7 +34,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers &, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers &, size_t result, size_t input_rows_count) const override { block.getByPosition(result).column = block.getByPosition(result).type->createColumnConst( input_rows_count, getFQDNOrHostName())->convertToFullColumnIfConst(); diff --git a/src/Functions/FunctionMathBinaryFloat64.h b/src/Functions/FunctionMathBinaryFloat64.h index f696e4728fb..023c23cde72 100644 --- a/src/Functions/FunctionMathBinaryFloat64.h +++ b/src/Functions/FunctionMathBinaryFloat64.h @@ -61,7 +61,7 @@ private: } template - bool executeTyped(Block & block, const size_t result, const ColumnConst * left_arg, const IColumn * right_arg) + bool executeTyped(Block & block, const size_t result, const ColumnConst * left_arg, const IColumn * right_arg) const { if (const auto right_arg_typed = checkAndGetColumn>(right_arg)) { @@ -100,7 +100,7 @@ private: } template - bool executeTyped(Block & block, const size_t result, const ColumnVector * left_arg, const IColumn * right_arg) + bool executeTyped(Block & block, const size_t result, const ColumnVector * left_arg, const IColumn * right_arg) const { if (const auto right_arg_typed = checkAndGetColumn>(right_arg)) { @@ -172,7 +172,7 @@ private: return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnWithTypeAndName & col_left = block.getByPosition(arguments[0]); const ColumnWithTypeAndName & col_right = block.getByPosition(arguments[1]); diff --git a/src/Functions/FunctionMathConstFloat64.h b/src/Functions/FunctionMathConstFloat64.h index a825679abb5..aaa06043459 100644 --- a/src/Functions/FunctionMathConstFloat64.h +++ b/src/Functions/FunctionMathConstFloat64.h @@ -25,7 +25,7 @@ private: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers &, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers &, size_t result, size_t input_rows_count) const override { block.getByPosition(result).column = block.getByPosition(result).type->createColumnConst(input_rows_count, Impl::value); } diff --git a/src/Functions/FunctionMathUnary.h b/src/Functions/FunctionMathUnary.h index b048b994951..ae1192c61df 100644 --- a/src/Functions/FunctionMathUnary.h +++ b/src/Functions/FunctionMathUnary.h @@ -143,7 +143,7 @@ private: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnWithTypeAndName & col = block.getByPosition(arguments[0]); diff --git a/src/Functions/FunctionNumericPredicate.h b/src/Functions/FunctionNumericPredicate.h index 4b718feab9b..21bd866ecc3 100644 --- a/src/Functions/FunctionNumericPredicate.h +++ b/src/Functions/FunctionNumericPredicate.h @@ -45,7 +45,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto in = block.getByPosition(arguments.front()).column.get(); @@ -63,7 +63,7 @@ public: } template - bool execute(Block & block, const IColumn * in_untyped, const size_t result) + bool execute(Block & block, const IColumn * in_untyped, const size_t result) const { if (const auto in = checkAndGetColumn>(in_untyped)) { diff --git a/src/Functions/FunctionStartsEndsWith.h b/src/Functions/FunctionStartsEndsWith.h index 69627eb2ead..1587fa21cec 100644 --- a/src/Functions/FunctionStartsEndsWith.h +++ b/src/Functions/FunctionStartsEndsWith.h @@ -62,7 +62,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IColumn * haystack_column = block.getByPosition(arguments[0]).column.get(); const IColumn * needle_column = block.getByPosition(arguments[1]).column.get(); @@ -158,7 +158,7 @@ public: #endif } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { selector.selectAndExecute(block, arguments, result, input_rows_count); } diff --git a/src/Functions/FunctionStringOrArrayToT.h b/src/Functions/FunctionStringOrArrayToT.h index bdb2759e252..35f8e0fb97a 100644 --- a/src/Functions/FunctionStringOrArrayToT.h +++ b/src/Functions/FunctionStringOrArrayToT.h @@ -49,7 +49,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr column = block.getByPosition(arguments[0]).column; if (const ColumnString * col = checkAndGetColumn(column.get())) diff --git a/src/Functions/FunctionStringReplace.h b/src/Functions/FunctionStringReplace.h index 8737f9eb31f..a1cb5f22d0b 100644 --- a/src/Functions/FunctionStringReplace.h +++ b/src/Functions/FunctionStringReplace.h @@ -52,7 +52,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr column_src = block.getByPosition(arguments[0]).column; const ColumnPtr column_needle = block.getByPosition(arguments[1]).column; diff --git a/src/Functions/FunctionStringToString.h b/src/Functions/FunctionStringToString.h index 8bc8ad8575d..827a81af158 100644 --- a/src/Functions/FunctionStringToString.h +++ b/src/Functions/FunctionStringToString.h @@ -51,7 +51,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr column = block.getByPosition(arguments[0]).column; if (const ColumnString * col = checkAndGetColumn(column.get())) diff --git a/src/Functions/FunctionUnaryArithmetic.h b/src/Functions/FunctionUnaryArithmetic.h index 94cd2c538d6..abd38d1e92f 100644 --- a/src/Functions/FunctionUnaryArithmetic.h +++ b/src/Functions/FunctionUnaryArithmetic.h @@ -152,7 +152,7 @@ public: return result; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { bool valid = castType(block.getByPosition(arguments[0]).type.get(), [&](const auto & type) { diff --git a/src/Functions/FunctionUnixTimestamp64.h b/src/Functions/FunctionUnixTimestamp64.h index 2d3d12a4d0a..c637a1f4660 100644 --- a/src/Functions/FunctionUnixTimestamp64.h +++ b/src/Functions/FunctionUnixTimestamp64.h @@ -64,7 +64,7 @@ public: } } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { using SourceColumnType = typename SourceDataType::ColumnType; using ResultColumnType = typename ResultDataType::ColumnType; diff --git a/src/Functions/FunctionsBitmap.h b/src/Functions/FunctionsBitmap.h index 868bf8095a4..9e58eb67a1b 100644 --- a/src/Functions/FunctionsBitmap.h +++ b/src/Functions/FunctionsBitmap.h @@ -122,7 +122,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /* input_rows_count */) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /* input_rows_count */) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); auto array_type = typeid_cast(from_type); @@ -146,7 +146,7 @@ public: private: template - void executeBitmapData(Block & block, DataTypes & argument_types, const ColumnNumbers & arguments, size_t result) + void executeBitmapData(Block & block, DataTypes & argument_types, const ColumnNumbers & arguments, size_t result) const { // input data const ColumnArray * array = typeid_cast(block.getByPosition(arguments[0]).column.get()); @@ -207,7 +207,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { // input data const auto & return_type = block.getByPosition(result).type; @@ -299,7 +299,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); const DataTypeAggregateFunction * aggr_type = typeid_cast(from_type); @@ -435,7 +435,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); const DataTypeAggregateFunction * aggr_type = typeid_cast(from_type); @@ -568,7 +568,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { auto col_to = ColumnVector::create(input_rows_count); typename ColumnVector::Container & vec_to = col_to->getData(); @@ -596,7 +596,7 @@ private: template void executeIntType( - Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) + Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) const { const ColumnAggregateFunction * column = typeid_cast(block.getByPosition(arguments[0]).column.get()); @@ -738,7 +738,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { auto col_to = ColumnVector::create(input_rows_count); typename ColumnVector::Container & vec_to = col_to->getData(); @@ -764,7 +764,7 @@ public: private: template void executeIntType( - Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) + Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) const { const IColumn * columns[2]; bool is_column_const[2]; @@ -835,7 +835,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { auto col_to = ColumnVector::create(input_rows_count); typename ColumnVector::Container & vec_to = col_to->getData(); @@ -861,7 +861,7 @@ public: private: template void executeIntType( - Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) + Block & block, const ColumnNumbers & arguments, size_t input_rows_count, typename ColumnVector::Container & vec_to) const { const ColumnAggregateFunction * columns[2]; bool is_column_const[2]; @@ -970,7 +970,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); const DataTypeAggregateFunction * aggr_type = typeid_cast(from_type); @@ -990,7 +990,7 @@ public: private: template - void executeBitmapData(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) + void executeBitmapData(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const { const ColumnAggregateFunction * columns[2]; bool is_column_const[2]; diff --git a/src/Functions/FunctionsCoding.h b/src/Functions/FunctionsCoding.h index 6a3d6db546c..12bbd913788 100644 --- a/src/Functions/FunctionsCoding.h +++ b/src/Functions/FunctionsCoding.h @@ -88,7 +88,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto & col_type_name = block.getByPosition(arguments[0]); const ColumnPtr & column = col_type_name.column; @@ -168,7 +168,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1, 2}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto & col_type_name = block.getByPosition(arguments[0]); const ColumnPtr & column = col_type_name.column; @@ -249,7 +249,7 @@ private: ((unalignedLoad(address + 8) & 0x00000000FFFFFFFFull) == 0x00000000FFFF0000ull); } - void cutAddress(const unsigned char * address, char *& dst, UInt8 zeroed_tail_bytes_count) + void cutAddress(const unsigned char * address, char *& dst, UInt8 zeroed_tail_bytes_count) const { formatIPv6(address, dst, zeroed_tail_bytes_count); } @@ -277,7 +277,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -339,7 +339,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -407,7 +407,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -460,7 +460,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto & col_type_name = block.getByPosition(arguments[0]); const ColumnPtr & column = col_type_name.column; @@ -578,7 +578,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -688,7 +688,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -755,7 +755,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnWithTypeAndName & col_type_name = block.getByPosition(arguments[0]); const ColumnPtr & column = col_type_name.column; @@ -857,7 +857,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnWithTypeAndName & col_type_name = block.getByPosition(arguments[0]); const ColumnPtr & column = col_type_name.column; @@ -959,7 +959,7 @@ public: } template - void executeOneUInt(T x, char *& out) + void executeOneUInt(T x, char *& out) const { bool was_nonzero = false; for (int offset = (sizeof(T) - 1) * 8; offset >= 0; offset -= 8) @@ -980,7 +980,7 @@ public: } template - bool tryExecuteUInt(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteUInt(const IColumn * col, ColumnPtr & col_res) const { const ColumnVector * col_vec = checkAndGetColumn>(col); @@ -1025,7 +1025,7 @@ public: } template - void executeFloatAndDecimal(const T & in_vec, ColumnPtr & col_res, const size_t type_size_in_bytes) + void executeFloatAndDecimal(const T & in_vec, ColumnPtr & col_res, const size_t type_size_in_bytes) const { const size_t hex_length = type_size_in_bytes * 2 + 1; /// Including trailing zero byte. auto col_str = ColumnString::create(); @@ -1051,7 +1051,7 @@ public: } template - bool tryExecuteFloat(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteFloat(const IColumn * col, ColumnPtr & col_res) const { const ColumnVector * col_vec = checkAndGetColumn>(col); if (col_vec) @@ -1067,7 +1067,7 @@ public: } template - bool tryExecuteDecimal(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteDecimal(const IColumn * col, ColumnPtr & col_res) const { const ColumnDecimal * col_dec = checkAndGetColumn>(col); if (col_dec) @@ -1083,7 +1083,7 @@ public: } - void executeOneString(const UInt8 * pos, const UInt8 * end, char *& out) + void executeOneString(const UInt8 * pos, const UInt8 * end, char *& out) const { while (pos < end) { @@ -1095,7 +1095,7 @@ public: ++out; } - bool tryExecuteString(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteString(const IColumn * col, ColumnPtr & col_res) const { const ColumnString * col_str_in = checkAndGetColumn(col); @@ -1139,7 +1139,7 @@ public: } } - bool tryExecuteFixedString(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteFixedString(const IColumn * col, ColumnPtr & col_res) const { const ColumnFixedString * col_fstr_in = checkAndGetColumn(col); @@ -1187,7 +1187,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const IColumn * column = block.getByPosition(arguments[0]).column.get(); ColumnPtr & res_column = block.getByPosition(result).column; @@ -1235,7 +1235,7 @@ public: return std::make_shared(); } - void unhexOne(const char * pos, const char * end, char *& out) + void unhexOne(const char * pos, const char * end, char *& out) const { if ((end - pos) & 1) { @@ -1255,7 +1255,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const ColumnPtr & column = block.getByPosition(arguments[0]).column; @@ -1335,7 +1335,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { auto col_str = ColumnString::create(); ColumnString::Chars & out_vec = col_str->getChars(); @@ -1379,7 +1379,7 @@ public: private: template - bool executeNumber(const IColumn & src_data, ColumnString::Chars & out_vec, const size_t & column_idx, const size_t & rows, const size_t & size_per_row) + bool executeNumber(const IColumn & src_data, ColumnString::Chars & out_vec, const size_t & column_idx, const size_t & rows, const size_t & size_per_row) const { const ColumnVector * src_data_concrete = checkAndGetColumn>(&src_data); @@ -1422,7 +1422,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } template - bool tryExecute(const IColumn * column, ColumnPtr & out_column) + bool tryExecute(const IColumn * column, ColumnPtr & out_column) const { using UnsignedT = std::make_unsigned_t; @@ -1461,7 +1461,7 @@ public: } } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const IColumn * in_column = block.getByPosition(arguments[0]).column.get(); ColumnPtr & out_column = block.getByPosition(result).column; @@ -1506,7 +1506,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - bool tryExecuteString(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteString(const IColumn * col, ColumnPtr & col_res) const { const ColumnString * col_str_in = checkAndGetColumn(col); @@ -1553,7 +1553,7 @@ public: } } - bool tryExecuteFixedString(const IColumn * col, ColumnPtr & col_res) + bool tryExecuteFixedString(const IColumn * col, ColumnPtr & col_res) const { const ColumnFixedString * col_fstr_in = checkAndGetColumn(col); @@ -1599,7 +1599,7 @@ public: } } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const IColumn * column = block.getByPosition(arguments[0]).column.get(); ColumnPtr & res_column = block.getByPosition(result).column; @@ -1668,7 +1668,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const auto & col_type_name_ip = block.getByPosition(arguments[0]); const ColumnPtr & column_ip = col_type_name_ip.column; @@ -1772,7 +1772,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const auto & col_type_name_ip = block.getByPosition(arguments[0]); const ColumnPtr & column_ip = col_type_name_ip.column; diff --git a/src/Functions/FunctionsComparison.h b/src/Functions/FunctionsComparison.h index 577ea19fe8a..a2d39814f7d 100644 --- a/src/Functions/FunctionsComparison.h +++ b/src/Functions/FunctionsComparison.h @@ -566,7 +566,7 @@ private: bool check_decimal_overflow = true; template - bool executeNumRightType(Block & block, size_t result, const ColumnVector * col_left, const IColumn * col_right_untyped) + bool executeNumRightType(Block & block, size_t result, const ColumnVector * col_left, const IColumn * col_right_untyped) const { if (const ColumnVector * col_right = checkAndGetColumn>(col_right_untyped)) { @@ -595,7 +595,7 @@ private: } template - bool executeNumConstRightType(Block & block, size_t result, const ColumnConst * col_left, const IColumn * col_right_untyped) + bool executeNumConstRightType(Block & block, size_t result, const ColumnConst * col_left, const IColumn * col_right_untyped) const { if (const ColumnVector * col_right = checkAndGetColumn>(col_right_untyped)) { @@ -621,7 +621,7 @@ private: } template - bool executeNumLeftType(Block & block, size_t result, const IColumn * col_left_untyped, const IColumn * col_right_untyped) + bool executeNumLeftType(Block & block, size_t result, const IColumn * col_left_untyped, const IColumn * col_right_untyped) const { if (const ColumnVector * col_left = checkAndGetColumn>(col_left_untyped)) { @@ -667,7 +667,7 @@ private: return false; } - void executeDecimal(Block & block, size_t result, const ColumnWithTypeAndName & col_left, const ColumnWithTypeAndName & col_right) + void executeDecimal(Block & block, size_t result, const ColumnWithTypeAndName & col_left, const ColumnWithTypeAndName & col_right) const { TypeIndex left_number = col_left.type->getTypeId(); TypeIndex right_number = col_right.type->getTypeId(); @@ -690,7 +690,7 @@ private: ErrorCodes::LOGICAL_ERROR); } - bool executeString(Block & block, size_t result, const IColumn * c0, const IColumn * c1) + bool executeString(Block & block, size_t result, const IColumn * c0, const IColumn * c1) const { const ColumnString * c0_string = checkAndGetColumn(c0); const ColumnString * c1_string = checkAndGetColumn(c1); @@ -816,7 +816,7 @@ private: bool executeWithConstString( Block & block, size_t result, const IColumn * col_left_untyped, const IColumn * col_right_untyped, - const DataTypePtr & left_type, const DataTypePtr & right_type, size_t input_rows_count) + const DataTypePtr & left_type, const DataTypePtr & right_type, size_t input_rows_count) const { /// To compare something with const string, we cast constant to appropriate type and compare as usual. /// It is ok to throw exception if value is not convertible. @@ -860,7 +860,7 @@ private: } void executeTuple(Block & block, size_t result, const ColumnWithTypeAndName & c0, const ColumnWithTypeAndName & c1, - size_t input_rows_count) + size_t input_rows_count) const { /** We will lexicographically compare the tuples. This is done as follows: * x == y : x1 == y1 && x2 == y2 ... @@ -917,7 +917,7 @@ private: void executeTupleImpl(Block & block, size_t result, const ColumnsWithTypeAndName & x, const ColumnsWithTypeAndName & y, size_t tuple_size, - size_t input_rows_count); + size_t input_rows_count) const; void executeTupleEqualityImpl( std::shared_ptr func_compare, @@ -927,7 +927,7 @@ private: const ColumnsWithTypeAndName & x, const ColumnsWithTypeAndName & y, size_t tuple_size, - size_t input_rows_count) + size_t input_rows_count) const { if (0 == tuple_size) throw Exception("Comparison of zero-sized tuples is not implemented.", ErrorCodes::NOT_IMPLEMENTED); @@ -979,7 +979,7 @@ private: const ColumnsWithTypeAndName & x, const ColumnsWithTypeAndName & y, size_t tuple_size, - size_t input_rows_count) + size_t input_rows_count) const { Block tmp_block; @@ -1051,7 +1051,7 @@ private: block.getByPosition(result).column = tmp_block.getByPosition(tmp_block.columns() - 1).column; } - void executeGenericIdenticalTypes(Block & block, size_t result, const IColumn * c0, const IColumn * c1) + void executeGenericIdenticalTypes(Block & block, size_t result, const IColumn * c0, const IColumn * c1) const { bool c0_const = isColumnConst(*c0); bool c1_const = isColumnConst(*c1); @@ -1079,7 +1079,7 @@ private: } } - void executeGeneric(Block & block, size_t result, const ColumnWithTypeAndName & c0, const ColumnWithTypeAndName & c1) + void executeGeneric(Block & block, size_t result, const ColumnWithTypeAndName & c0, const ColumnWithTypeAndName & c1) const { DataTypePtr common_type = getLeastSupertype({c0.type, c1.type}); @@ -1153,7 +1153,7 @@ public: return std::make_shared(); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const auto & col_with_type_and_name_left = block.getByPosition(arguments[0]); const auto & col_with_type_and_name_right = block.getByPosition(arguments[1]); diff --git a/src/Functions/FunctionsConsistentHashing.h b/src/Functions/FunctionsConsistentHashing.h index 59bc8e2f521..a30289ed41e 100644 --- a/src/Functions/FunctionsConsistentHashing.h +++ b/src/Functions/FunctionsConsistentHashing.h @@ -65,7 +65,7 @@ public: return {1}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { if (isColumnConst(*block.getByPosition(arguments[1]).column)) executeConstBuckets(block, arguments, result); @@ -80,7 +80,7 @@ private: using BucketsType = typename Impl::BucketsType; template - inline BucketsType checkBucketsRange(T buckets) + inline BucketsType checkBucketsRange(T buckets) const { if (unlikely(buckets <= 0)) throw Exception( @@ -93,7 +93,7 @@ private: return static_cast(buckets); } - void executeConstBuckets(Block & block, const ColumnNumbers & arguments, size_t result) + void executeConstBuckets(Block & block, const ColumnNumbers & arguments, size_t result) const { Field buckets_field = (*block.getByPosition(arguments[1]).column)[0]; BucketsType num_buckets; @@ -136,7 +136,7 @@ private: } template - void executeType(const ColumnPtr & col_hash_ptr, BucketsType num_buckets, ColumnVector * col_result) + void executeType(const ColumnPtr & col_hash_ptr, BucketsType num_buckets, ColumnVector * col_result) const { auto col_hash = checkAndGetColumn>(col_hash_ptr.get()); if (!col_hash) diff --git a/src/Functions/FunctionsConversion.h b/src/Functions/FunctionsConversion.h index 932a8cd5bed..2327bce5e45 100644 --- a/src/Functions/FunctionsConversion.h +++ b/src/Functions/FunctionsConversion.h @@ -995,7 +995,7 @@ public: ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1}; } bool canBeExecutedOnDefaultArguments() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { try { @@ -1040,7 +1040,7 @@ public: } private: - void executeInternal(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) + void executeInternal(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const { if (!arguments.size()) throw Exception{"Function " + getName() + " expects at least 1 arguments", @@ -1223,7 +1223,7 @@ public: return res; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); diff --git a/src/Functions/FunctionsEmbeddedDictionaries.h b/src/Functions/FunctionsEmbeddedDictionaries.h index d337f9ea363..85d142a44ae 100644 --- a/src/Functions/FunctionsEmbeddedDictionaries.h +++ b/src/Functions/FunctionsEmbeddedDictionaries.h @@ -183,7 +183,7 @@ public: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { /// The dictionary key that defines the "point of view". std::string dict_key; @@ -279,7 +279,7 @@ public: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { /// The dictionary key that defines the "point of view". std::string dict_key; @@ -415,7 +415,7 @@ public: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { /// The dictionary key that defines the "point of view". std::string dict_key; @@ -620,7 +620,7 @@ public: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { RegionsNames::Language language = RegionsNames::Language::ru; diff --git a/src/Functions/FunctionsExternalDictionaries.h b/src/Functions/FunctionsExternalDictionaries.h index bace458b7da..c7194335ff3 100644 --- a/src/Functions/FunctionsExternalDictionaries.h +++ b/src/Functions/FunctionsExternalDictionaries.h @@ -160,7 +160,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { /** Do not require existence of the dictionary if the function is called for empty block. * This is needed to allow successful query analysis on a server, @@ -200,7 +200,7 @@ private: template bool executeDispatchSimple( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -223,7 +223,7 @@ private: template bool executeDispatchComplex( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -323,7 +323,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -357,7 +357,7 @@ private: template bool executeDispatch( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -388,7 +388,7 @@ private: template bool executeDispatchComplex( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -425,7 +425,7 @@ private: template bool executeDispatchRange( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -507,7 +507,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -540,7 +540,7 @@ private: template bool executeDispatch( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -566,7 +566,7 @@ private: template void executeDispatch( Block & block, const ColumnNumbers & arguments, const size_t result, const DictionaryType * dict, - const std::string & attr_name, const ColumnUInt64 * id_col) + const std::string & attr_name, const ColumnUInt64 * id_col) const { const auto default_col_untyped = block.getByPosition(arguments[3]).column.get(); @@ -594,7 +594,7 @@ private: template void executeDispatch( Block & block, const ColumnNumbers & arguments, const size_t result, const DictionaryType * dict, - const std::string & attr_name, const ColumnConst * id_col) + const std::string & attr_name, const ColumnConst * id_col) const { const auto default_col_untyped = block.getByPosition(arguments[3]).column.get(); @@ -628,7 +628,7 @@ private: template bool executeDispatchComplex( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -847,7 +847,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -880,7 +880,7 @@ private: } template - bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -936,7 +936,7 @@ private: template bool executeDispatchComplex( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -979,7 +979,7 @@ private: template bool executeDispatchRange( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -1108,7 +1108,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -1140,7 +1140,7 @@ private: } template - bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -1166,7 +1166,7 @@ private: template void executeDispatch( Block & block, const ColumnNumbers & arguments, const size_t result, const DictionaryType * dict, - const std::string & attr_name, const ColumnUInt64 * id_col) + const std::string & attr_name, const ColumnUInt64 * id_col) const { const auto default_col_untyped = block.getByPosition(arguments[3]).column.get(); @@ -1205,7 +1205,7 @@ private: template void executeDispatch( Block & block, const ColumnNumbers & arguments, const size_t result, const DictionaryType * dict, - const std::string & attr_name, const ColumnConst * id_col) + const std::string & attr_name, const ColumnConst * id_col) const { const auto default_col_untyped = block.getByPosition(arguments[3]).column.get(); @@ -1263,7 +1263,7 @@ private: template bool executeDispatchComplex( - Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) + Block & block, const ColumnNumbers & arguments, const size_t result, const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -1490,7 +1490,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { impl->executeImpl(block, arguments, result, input_rows_count); } @@ -1632,7 +1632,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { impl->executeImpl(block, arguments, result, input_rows_count); } @@ -1681,7 +1681,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -1701,7 +1701,7 @@ private: template bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, - const std::shared_ptr & dict_ptr) + const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -1838,7 +1838,7 @@ private: bool isDeterministic() const override { return false; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { if (input_rows_count == 0) { @@ -1858,7 +1858,7 @@ private: template bool executeDispatch(Block & block, const ColumnNumbers & arguments, const size_t result, - const std::shared_ptr & dict_ptr) + const std::shared_ptr & dict_ptr) const { const auto dict = typeid_cast(dict_ptr.get()); if (!dict) @@ -1883,7 +1883,7 @@ private: template bool execute(Block & block, const size_t result, const DictionaryType * dict, - const ColumnUInt64 * child_id_col, const IColumn * ancestor_id_col_untyped) + const ColumnUInt64 * child_id_col, const IColumn * ancestor_id_col_untyped) const { if (const auto ancestor_id_col = checkAndGetColumn(ancestor_id_col_untyped)) { @@ -1922,7 +1922,7 @@ private: template bool execute(Block & block, const size_t result, const DictionaryType * dict, - const ColumnConst * child_id_col, const IColumn * ancestor_id_col_untyped) + const ColumnConst * child_id_col, const IColumn * ancestor_id_col_untyped) const { if (const auto ancestor_id_col = checkAndGetColumn(ancestor_id_col_untyped)) { diff --git a/src/Functions/FunctionsExternalModels.cpp b/src/Functions/FunctionsExternalModels.cpp index f570fb661dd..cf0d058c483 100644 --- a/src/Functions/FunctionsExternalModels.cpp +++ b/src/Functions/FunctionsExternalModels.cpp @@ -71,7 +71,7 @@ DataTypePtr FunctionModelEvaluate::getReturnTypeImpl(const ColumnsWithTypeAndNam return type; } -void FunctionModelEvaluate::executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) +void FunctionModelEvaluate::executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const { const auto * name_col = checkAndGetColumnConst(block.getByPosition(arguments[0]).column.get()); if (!name_col) diff --git a/src/Functions/FunctionsExternalModels.h b/src/Functions/FunctionsExternalModels.h index b5f11804ab2..7cbe703d106 100644 --- a/src/Functions/FunctionsExternalModels.h +++ b/src/Functions/FunctionsExternalModels.h @@ -31,7 +31,7 @@ public: DataTypePtr getReturnTypeImpl(const ColumnsWithTypeAndName & arguments) const override; - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override; + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override; private: const ExternalModelsLoader & models_loader; diff --git a/src/Functions/FunctionsFormatting.h b/src/Functions/FunctionsFormatting.h index a5c5635e0ad..05bba6ae7e1 100644 --- a/src/Functions/FunctionsFormatting.h +++ b/src/Functions/FunctionsFormatting.h @@ -56,7 +56,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { if (!(executeType(block, arguments, result) || executeType(block, arguments, result) @@ -92,7 +92,7 @@ private: } template - bool executeType(Block & block, const ColumnNumbers & arguments, size_t result) + bool executeType(Block & block, const ColumnNumbers & arguments, size_t result) const { if (const ColumnVector * col_from = checkAndGetColumn>(block.getByPosition(arguments[0]).column.get())) { @@ -152,7 +152,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { if (!(executeType(block, arguments, result) || executeType(block, arguments, result) @@ -171,7 +171,7 @@ public: private: template - bool executeType(Block & block, const ColumnNumbers & arguments, size_t result) + bool executeType(Block & block, const ColumnNumbers & arguments, size_t result) const { if (const ColumnVector * col_from = checkAndGetColumn>(block.getByPosition(arguments[0]).column.get())) { diff --git a/src/Functions/FunctionsHashing.h b/src/Functions/FunctionsHashing.h index 2b0aebc8143..770da2c0477 100644 --- a/src/Functions/FunctionsHashing.h +++ b/src/Functions/FunctionsHashing.h @@ -542,7 +542,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { if (const ColumnString * col_from = checkAndGetColumn(block.getByPosition(arguments[0]).column.get())) { @@ -603,7 +603,7 @@ private: using ToType = typename Impl::ReturnType; template - void executeType(Block & block, const ColumnNumbers & arguments, size_t result) + void executeType(Block & block, const ColumnNumbers & arguments, size_t result) const { if (auto col_from = checkAndGetColumn>(block.getByPosition(arguments[0]).column.get())) { @@ -644,7 +644,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const IDataType * from_type = block.getByPosition(arguments[0]).type.get(); WhichDataType which(from_type); @@ -684,7 +684,7 @@ public: #endif } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { selector.selectAndExecute(block, arguments, result, input_rows_count); } @@ -710,7 +710,7 @@ private: using ToType = typename Impl::ReturnType; template - void executeIntType(const IColumn * column, typename ColumnVector::Container & vec_to) + void executeIntType(const IColumn * column, typename ColumnVector::Container & vec_to) const { if (const ColumnVector * col_from = checkAndGetColumn>(column)) { @@ -765,7 +765,7 @@ private: } template - void executeGeneric(const IColumn * column, typename ColumnVector::Container & vec_to) + void executeGeneric(const IColumn * column, typename ColumnVector::Container & vec_to) const { for (size_t i = 0, size = column->size(); i < size; ++i) { @@ -779,7 +779,7 @@ private: } template - void executeString(const IColumn * column, typename ColumnVector::Container & vec_to) + void executeString(const IColumn * column, typename ColumnVector::Container & vec_to) const { if (const ColumnString * col_from = checkAndGetColumn(column)) { @@ -842,7 +842,7 @@ private: } template - void executeArray(const IDataType * type, const IColumn * column, typename ColumnVector::Container & vec_to) + void executeArray(const IDataType * type, const IColumn * column, typename ColumnVector::Container & vec_to) const { const IDataType * nested_type = typeid_cast(type)->getNestedType().get(); @@ -892,7 +892,7 @@ private: } template - void executeAny(const IDataType * from_type, const IColumn * icolumn, typename ColumnVector::Container & vec_to) + void executeAny(const IDataType * from_type, const IColumn * icolumn, typename ColumnVector::Container & vec_to) const { WhichDataType which(from_type); @@ -917,7 +917,7 @@ private: executeGeneric(icolumn, vec_to); } - void executeForArgument(const IDataType * type, const IColumn * column, typename ColumnVector::Container & vec_to, bool & is_first) + void executeForArgument(const IDataType * type, const IColumn * column, typename ColumnVector::Container & vec_to, bool & is_first) const { /// Flattening of tuples. if (const ColumnTuple * tuple = typeid_cast(column)) @@ -965,7 +965,7 @@ public: return std::make_shared>(); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { size_t rows = input_rows_count; auto col_to = ColumnVector::create(rows); @@ -1010,7 +1010,7 @@ public: #endif } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t input_rows_count) const override { selector.selectAndExecute(block, arguments, result, input_rows_count); } @@ -1133,7 +1133,7 @@ public: bool useDefaultImplementationForConstants() const override { return true; } ColumnNumbers getArgumentsThatAreAlwaysConstant() const override { return {1}; } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result, size_t /*input_rows_count*/) const override { const auto arg_count = arguments.size(); diff --git a/src/Functions/FunctionsJSON.h b/src/Functions/FunctionsJSON.h index 5d0a2924f05..4ffa835fda6 100644 --- a/src/Functions/FunctionsJSON.h +++ b/src/Functions/FunctionsJSON.h @@ -286,7 +286,7 @@ public: return Impl::getReturnType(Name::name, arguments); } - void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result_pos, size_t input_rows_count) override + void executeImpl(Block & block, const ColumnNumbers & arguments, size_t result_pos, size_t input_rows_count) const override { /// Choose JSONParser. #if USE_SIMDJSON diff --git a/src/Functions/FunctionsLogical.cpp b/src/Functions/FunctionsLogical.cpp index 9419696ef99..879993ccc1a 100644 --- a/src/Functions/FunctionsLogical.cpp +++ b/src/Functions/FunctionsLogical.cpp @@ -499,7 +499,7 @@ DataTypePtr FunctionAnyArityLogical::getReturnTypeImpl(const DataTyp template void FunctionAnyArityLogical::executeImpl( - Block & block, const ColumnNumbers & arguments, size_t result_index, size_t input_rows_count) + Block & block, const ColumnNumbers & arguments, size_t result_index, size_t input_rows_count) const { ColumnRawPtrs args_in; for (const auto arg_index : arguments) @@ -559,7 +559,7 @@ bool functionUnaryExecuteType(Block & block, const ColumnNumbers & arguments, si } template