From a90e10c438e58e896482f958ca905e7dc21a9993 Mon Sep 17 00:00:00 2001
From: Shaun Struwig <41984034+Blargian@users.noreply.github.com>
Date: Sat, 13 Jul 2024 22:38:28 +0000
Subject: [PATCH] add alias partitionI, update tests, and docs

---
 docs/en/sql-reference/functions/other-functions.md     | 10 +++++-----
 src/Functions/partitionId.cpp                          |  1 +
 tests/integration/test_lost_part/test.py               |  2 +-
 .../queries/0_stateless/01748_partition_id_pruning.sql |  6 +++---
 utils/check-style/aspell-ignore/en/aspell-dict.txt     |  1 +
 5 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/docs/en/sql-reference/functions/other-functions.md b/docs/en/sql-reference/functions/other-functions.md
index cb31d21e1b3..260457b3be1 100644
--- a/docs/en/sql-reference/functions/other-functions.md
+++ b/docs/en/sql-reference/functions/other-functions.md
@@ -2984,7 +2984,7 @@ Result:
 └─────────┘
 ```
 
-## partitionId
+## partitionID
 
 Computes the [partition ID](../../engines/table-engines/mergetree-family/custom-partitioning-key.md).
 
@@ -2995,7 +2995,7 @@ This function is slow and should not be called for large amount of rows.
 **Syntax**
 
 ```sql
-partitionId(x[, y, ...]);
+partitionID(x[, y, ...]);
 ```
 
 **Arguments**
@@ -3025,18 +3025,18 @@ ORDER BY tuple();
 
 INSERT INTO tab VALUES (1, 1), (1, 2), (1, 3), (2, 4), (2, 5), (2, 6);
 
-SELECT i, j, partitionId(i), _partition_id FROM tab ORDER BY i, j;
+SELECT i, j, partitionID(i), _partition_id FROM tab ORDER BY i, j;
 ```
 
 Result:
 
 ```response
-┌─i─┬─j─┬─partitionId(i)─┬─_partition_id─┐
+┌─i─┬─j─┬─partitionID(i)─┬─_partition_id─┐
 │ 1 │ 1 │ 1              │ 1             │
 │ 1 │ 2 │ 1              │ 1             │
 │ 1 │ 3 │ 1              │ 1             │
 └───┴───┴────────────────┴───────────────┘
-┌─i─┬─j─┬─partitionId(i)─┬─_partition_id─┐
+┌─i─┬─j─┬─partitionID(i)─┬─_partition_id─┐
 │ 2 │ 4 │ 2              │ 2             │
 │ 2 │ 5 │ 2              │ 2             │
 │ 2 │ 6 │ 2              │ 2             │
diff --git a/src/Functions/partitionId.cpp b/src/Functions/partitionId.cpp
index e2e9038cd8b..00ff3981c88 100644
--- a/src/Functions/partitionId.cpp
+++ b/src/Functions/partitionId.cpp
@@ -66,6 +66,7 @@ public:
 REGISTER_FUNCTION(PartitionId)
 {
     factory.registerFunction<FunctionPartitionId>();
+    factory.registerAlias("partitionID", "partitionId", FunctionFactory::CaseInsensitive);
 }
 
 }
diff --git a/tests/integration/test_lost_part/test.py b/tests/integration/test_lost_part/test.py
index b8e67551d79..c2469d6c524 100644
--- a/tests/integration/test_lost_part/test.py
+++ b/tests/integration/test_lost_part/test.py
@@ -266,7 +266,7 @@ def test_lost_last_part(start_cluster):
             "ALTER TABLE mt3 UPDATE id = 777 WHERE 1", settings={"mutations_sync": "0"}
         )
 
-        partition_id = node1.query("select partitionId('x')").strip()
+        partition_id = node1.query("select partitionID('x')").strip()
         remove_part_from_disk(node1, "mt3", f"{partition_id}_0_0_0")
 
         # other way to detect broken parts
diff --git a/tests/queries/0_stateless/01748_partition_id_pruning.sql b/tests/queries/0_stateless/01748_partition_id_pruning.sql
index b637528bc6c..f492a4a8871 100644
--- a/tests/queries/0_stateless/01748_partition_id_pruning.sql
+++ b/tests/queries/0_stateless/01748_partition_id_pruning.sql
@@ -8,17 +8,17 @@ insert into x values (1, 1), (1, 2), (1, 3), (2, 4), (2, 5), (2, 6);
 
 set max_rows_to_read = 3;
 
-select * from x where _partition_id = partitionId(1);
+select * from x where _partition_id = partitionID(1);
 
 set max_rows_to_read = 5; -- one row for subquery + subquery
 
-select * from x where _partition_id in (select partitionId(number + 1) from numbers(1));
+select * from x where _partition_id in (select partitionID(number + 1) from numbers(1));
 
 -- trivial count optimization test
 set max_rows_to_read = 2; -- one row for subquery + subquery itself
 -- TODO: Relax the limits because we might build prepared set twice with _minmax_count_projection
 set max_rows_to_read = 3;
-select count() from x where _partition_id in (select partitionId(number + 1) from numbers(1));
+select count() from x where _partition_id in (select partitionID(number + 1) from numbers(1));
 
 drop table x;
 
diff --git a/utils/check-style/aspell-ignore/en/aspell-dict.txt b/utils/check-style/aspell-ignore/en/aspell-dict.txt
index 935b08c1b88..e5f06b468a0 100644
--- a/utils/check-style/aspell-ignore/en/aspell-dict.txt
+++ b/utils/check-style/aspell-ignore/en/aspell-dict.txt
@@ -2193,6 +2193,7 @@ parseTimeDelta
 parseable
 parsers
 partitionId
+partitionID
 pathFull
 pclmulqdq
 pcre