Merge branch 'master' into planner-prepare-filters-for-analysis-2

docs/en/sql-reference/aggregate-functions/reference/studentttest.md

@@ -33,8 +33,8 @@ The null hypothesis is that means of populations are equal. Normal distribution
 
 - calculated t-statistic. [Float64](../../../sql-reference/data-types/float.md).
 - calculated p-value. [Float64](../../../sql-reference/data-types/float.md).
-- [calculated confidence-interval-low.] [Float64](../../../sql-reference/data-types/float.md).
-- [calculated confidence-interval-high.] [Float64](../../../sql-reference/data-types/float.md).
+- [calculated confidence-interval-low. [Float64](../../../sql-reference/data-types/float.md).]
+- [calculated confidence-interval-high. [Float64](../../../sql-reference/data-types/float.md).]
 
 
 **Example**

docs/en/sql-reference/functions/date-time-functions.md

@@ -134,7 +134,7 @@ Like [makeDateTime](#makedatetime) but produces a [DateTime64](../../sql-referen
 **Syntax**
 
 ``` sql
-makeDateTime32(year, month, day, hour, minute, second[, fraction[, precision[, timezone]]])
+makeDateTime64(year, month, day, hour, minute, second[, fraction[, precision[, timezone]]])
 ```
 
 ## timestamp

docs/en/sql-reference/statements/truncate.md

@@ -25,7 +25,7 @@ If the `alter_sync` is set to `2` and some replicas are not active for more than
 
 ## TRUNCATE DATABASE
 ``` sql
-TRUNCATE DATBASE [IF EXISTS] [db.]name [ON CLUSTER cluster]
+TRUNCATE DATABASE [IF EXISTS] [db.]name [ON CLUSTER cluster]
 ```
 
 Removes all tables from a database but keeps the database itself. When the clause `IF EXISTS` is omitted, the query returns an error if the database does not exist.

src/Client/ClientBaseHelpers.cpp

@@ -130,6 +130,7 @@ void highlight(const String & query, std::vector<replxx::Replxx::Color> & colors
             {TokenType::Greater, replxx::color::bold(Replxx::Color::DEFAULT)},
             {TokenType::LessOrEquals, replxx::color::bold(Replxx::Color::DEFAULT)},
             {TokenType::GreaterOrEquals, replxx::color::bold(Replxx::Color::DEFAULT)},
+            {TokenType::Spaceship, replxx::color::bold(Replxx::Color::DEFAULT)},
             {TokenType::Concatenation, replxx::color::bold(Replxx::Color::DEFAULT)},
             {TokenType::At, replxx::color::bold(Replxx::Color::DEFAULT)},
             {TokenType::DoubleAt, Replxx::Color::MAGENTA},

src/Common/FST.h

@@ -3,13 +3,13 @@
 #include <map>
 #include <memory>
 #include <string>
-#include <unordered_map>
 #include <unordered_set>
 #include <vector>
 #include <Core/Types.h>
 #include <IO/ReadHelpers.h>
 #include <IO/WriteBuffer.h>
 #include <base/types.h>
+#include <absl/container/flat_hash_map.h>
 
 namespace DB
 {
@@ -107,7 +107,7 @@ public:
     UInt64 state_index = 0;
 
     /// Arcs which are started from state, the 'char' is the label on the arc
-    std::unordered_map<char, Arc> arcs;
+    absl::flat_hash_map<char, Arc> arcs;
 
 private:
     struct FlagValues
@@ -146,7 +146,7 @@ private:
     StatePtr initial_state;
 
     /// map of (state_hash, StatePtr)
-    std::unordered_map<UInt64, StatePtr> minimized_states;
+    absl::flat_hash_map<UInt64, StatePtr> minimized_states;
 
     /// Next available ID of state
     UInt64 next_id = 1;

src/Storages/MergeTree/GinIndexStore.h

@@ -11,6 +11,7 @@
 #include <mutex>
 #include <unordered_map>
 #include <vector>
+#include <absl/container/flat_hash_map.h>
 
 /// GinIndexStore manages the generalized inverted index ("gin") for a data part, and it is made up of one or more immutable
 /// index segments.
@@ -124,7 +125,7 @@ class GinIndexStore
 {
 public:
     /// Container for all term's Gin Index Postings List Builder
-    using GinIndexPostingsBuilderContainer = std::unordered_map<std::string, GinIndexPostingsBuilderPtr>;
+    using GinIndexPostingsBuilderContainer = absl::flat_hash_map<std::string, GinIndexPostingsBuilderPtr>;
 
     GinIndexStore(const String & name_, DataPartStoragePtr storage_);
     GinIndexStore(const String & name_, DataPartStoragePtr storage_, MutableDataPartStoragePtr data_part_storage_builder_, UInt64 max_digestion_size_);

tests/ci/.mypy.ini

@@ -9,7 +9,8 @@ check_untyped_defs = True
 disallow_untyped_decorators = True
 no_implicit_optional = True
 warn_redundant_casts = True
-warn_unused_ignores = True
+# Unused ignores differs from version to version, so too many noizes
+warn_unused_ignores = False
 warn_return_any = True
 no_implicit_reexport = True
 strict_equality = True

tests/ci/cherry_pick.py

@@ -289,7 +289,9 @@ close it.
             "Checking if cherry-pick PR #%s needs to be pinged",
             self.cherrypick_pr.number,
         )
-        since_updated = datetime.now() - self.cherrypick_pr.updated_at
+        # The `updated_at` is Optional[datetime]
+        cherrypick_updated_at = self.cherrypick_pr.updated_at or datetime.now()
+        since_updated = datetime.now() - cherrypick_updated_at
         since_updated_str = (
             f"{since_updated.days}d{since_updated.seconds // 3600}"
             f"h{since_updated.seconds // 60 % 60}m{since_updated.seconds % 60}s"
@@ -298,7 +300,7 @@ close it.
             logging.info(
                 "The cherry-pick PR was updated at %s %s ago, "
                 "waiting for the next running",
-                self.cherrypick_pr.updated_at.isoformat(),
+                cherrypick_updated_at.isoformat(),
                 since_updated_str,
             )
             return

tests/ci/get_robot_token.py

@@ -1,16 +1,17 @@
 #!/usr/bin/env python3
 import logging
 from dataclasses import dataclass
-from typing import Any, Dict, List, Optional
+from typing import Any, Dict, List, Optional, Union
 
 import boto3  # type: ignore
 from github import Github
 from github.AuthenticatedUser import AuthenticatedUser
+from github.NamedUser import NamedUser
 
 
 @dataclass
 class Token:
-    user: AuthenticatedUser
+    user: Union[AuthenticatedUser, NamedUser]
     value: str
     rest: int
 

tests/ci/style_check.py

@@ -140,7 +140,7 @@ def main():
     stopwatch = Stopwatch()
 
     repo_path = Path(GITHUB_WORKSPACE)
-    temp_path = Path(TEMP_PATH) / "style_check"
+    temp_path = Path(TEMP_PATH)
     temp_path.mkdir(parents=True, exist_ok=True)
 
     pr_info = PRInfo()