From 2deb9643af5644d68d62b0808315e0fa853a25c2 Mon Sep 17 00:00:00 2001 From: bharatnc Date: Sat, 25 Sep 2021 10:12:32 -0700 Subject: [PATCH 1/4] Rename h3ResIsClassIII -> h3IsResClassIII --- .../{h3ResIsClassIII.cpp => h3IsResClassIII.cpp} | 10 +++++----- src/Functions/registerFunctionsGeo.cpp | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) rename src/Functions/{h3ResIsClassIII.cpp => h3IsResClassIII.cpp} (88%) diff --git a/src/Functions/h3ResIsClassIII.cpp b/src/Functions/h3IsResClassIII.cpp similarity index 88% rename from src/Functions/h3ResIsClassIII.cpp rename to src/Functions/h3IsResClassIII.cpp index 044e6d565ac..25a2fc1952f 100644 --- a/src/Functions/h3ResIsClassIII.cpp +++ b/src/Functions/h3IsResClassIII.cpp @@ -24,12 +24,12 @@ extern const int ILLEGAL_TYPE_OF_ARGUMENT; namespace { -class FunctionH3ResIsClassIII : public IFunction +class FunctionH3IsResClassIII : public IFunction { public: - static constexpr auto name = "h3ResIsClassIII"; + static constexpr auto name = "h3IsResClassIII"; - static FunctionPtr create(ContextPtr) { return std::make_shared(); } + static FunctionPtr create(ContextPtr) { return std::make_shared(); } std::string getName() const override { return name; } @@ -69,9 +69,9 @@ public: } -void registerFunctionH3ResIsClassIII(FunctionFactory & factory) +void registerFunctionH3IsResClassIII(FunctionFactory & factory) { - factory.registerFunction(); + factory.registerFunction(); } } diff --git a/src/Functions/registerFunctionsGeo.cpp b/src/Functions/registerFunctionsGeo.cpp index a86ff18ec65..a0ae38f6b85 100644 --- a/src/Functions/registerFunctionsGeo.cpp +++ b/src/Functions/registerFunctionsGeo.cpp @@ -42,7 +42,7 @@ void registerFunctionH3IndexesAreNeighbors(FunctionFactory &); void registerFunctionStringToH3(FunctionFactory &); void registerFunctionH3ToString(FunctionFactory &); void registerFunctionH3HexAreaM2(FunctionFactory &); -void registerFunctionH3ResIsClassIII(FunctionFactory &); +void registerFunctionH3IsResClassIII(FunctionFactory &); void registerFunctionH3IsPentagon(FunctionFactory &); void registerFunctionH3GetFaces(FunctionFactory &); #endif @@ -98,7 +98,7 @@ void registerFunctionsGeo(FunctionFactory & factory) registerFunctionStringToH3(factory); registerFunctionH3ToString(factory); registerFunctionH3HexAreaM2(factory); - registerFunctionH3ResIsClassIII(factory); + registerFunctionH3IsResClassIII(factory); registerFunctionH3IsPentagon(factory); registerFunctionH3GetFaces(factory); #endif From 79473f2edc4b2221d179a1a443ca7503399f2f6a Mon Sep 17 00:00:00 2001 From: bharatnc Date: Sat, 25 Sep 2021 10:13:42 -0700 Subject: [PATCH 2/4] Fix tests --- ...{2021_h3_res_is_classIII.sql => 2021_h3_is_res_classIII.sql} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename tests/queries/0_stateless/{2021_h3_res_is_classIII.sql => 2021_h3_is_res_classIII.sql} (88%) diff --git a/tests/queries/0_stateless/2021_h3_res_is_classIII.sql b/tests/queries/0_stateless/2021_h3_is_res_classIII.sql similarity index 88% rename from tests/queries/0_stateless/2021_h3_res_is_classIII.sql rename to tests/queries/0_stateless/2021_h3_is_res_classIII.sql index 67dae6d1fa2..7b9cc7acb48 100644 --- a/tests/queries/0_stateless/2021_h3_res_is_classIII.sql +++ b/tests/queries/0_stateless/2021_h3_is_res_classIII.sql @@ -11,6 +11,6 @@ INSERT INTO h3_indexes VALUES (geoToH3(10.0, 0.0, 1)); INSERT INTO h3_indexes VALUES (geoToH3(0.0, 10.0, 2)); INSERT INTO h3_indexes VALUES (geoToH3(10.0, 10.0, 3)); -SELECT h3ResIsClassIII(h3_index) FROM h3_indexes ORDER BY h3_index; +SELECT h3IsResClassIII(h3_index) FROM h3_indexes ORDER BY h3_index; DROP TABLE h3_indexes; From a5a8d132d0b4dfd0893608b54133505c01b18086 Mon Sep 17 00:00:00 2001 From: bharatnc Date: Sat, 25 Sep 2021 10:15:12 -0700 Subject: [PATCH 3/4] Fix doc references --- docs/en/sql-reference/functions/geo/h3.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/en/sql-reference/functions/geo/h3.md b/docs/en/sql-reference/functions/geo/h3.md index faa86527c7d..3c3ed7b8932 100644 --- a/docs/en/sql-reference/functions/geo/h3.md +++ b/docs/en/sql-reference/functions/geo/h3.md @@ -594,14 +594,14 @@ Result: └─────┘ ``` -## h3ResIsClassIII {#h3resisclassIII} +## h3IsResClassIII {#h3isresclassIII} Returns whether [H3](#h3index) index has a resolution with Class III orientation. **Syntax** ``` sql -h3ResIsClassIII(index) +h3IsResClassIII(index) ``` **Parameter** @@ -620,7 +620,7 @@ Type: [UInt8](../../../sql-reference/data-types/int-uint.md). Query: ``` sql -SELECT h3ResIsClassIII(617420388352917503) as res; +SELECT h3IsResClassIII(617420388352917503) as res; ``` Result: From cd178496079287e540c2c36fc2ccf11eb5a90183 Mon Sep 17 00:00:00 2001 From: bharatnc Date: Sat, 25 Sep 2021 13:11:23 -0700 Subject: [PATCH 4/4] fix test - rename reference file --- ...es_is_classIII.reference => 2021_h3_is_res_classIII.reference} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tests/queries/0_stateless/{2021_h3_res_is_classIII.reference => 2021_h3_is_res_classIII.reference} (100%) diff --git a/tests/queries/0_stateless/2021_h3_res_is_classIII.reference b/tests/queries/0_stateless/2021_h3_is_res_classIII.reference similarity index 100% rename from tests/queries/0_stateless/2021_h3_res_is_classIII.reference rename to tests/queries/0_stateless/2021_h3_is_res_classIII.reference