From abe40e21279176dde7ff12f6ba3868dc54eb2e33 Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Sun, 3 May 2020 01:34:50 +0300 Subject: [PATCH] Added required comment #10576 --- src/IO/S3Common.cpp | 5 +++-- src/IO/S3Common.h | 4 ++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/IO/S3Common.cpp b/src/IO/S3Common.cpp index f1b823f8555..599b12d8593 100644 --- a/src/IO/S3Common.cpp +++ b/src/IO/S3Common.cpp @@ -83,7 +83,8 @@ namespace S3 return ret; } - std::shared_ptr ClientFactory::create( + /// This method is not static because it requires ClientFactory to be initialized. + std::shared_ptr ClientFactory::create( // NOLINT const String & endpoint, const String & access_key_id, const String & secret_access_key) @@ -95,7 +96,7 @@ namespace S3 return create(cfg, access_key_id, secret_access_key); } - std::shared_ptr ClientFactory::create( + std::shared_ptr ClientFactory::create( // NOLINT Aws::Client::ClientConfiguration & cfg, const String & access_key_id, const String & secret_access_key) diff --git a/src/IO/S3Common.h b/src/IO/S3Common.h index 57bc0461f21..b4cc9031b81 100644 --- a/src/IO/S3Common.h +++ b/src/IO/S3Common.h @@ -23,12 +23,12 @@ public: static ClientFactory & instance(); - static std::shared_ptr create( + std::shared_ptr create( const String & endpoint, const String & access_key_id, const String & secret_access_key); - static std::shared_ptr create( + std::shared_ptr create( Aws::Client::ClientConfiguration & cfg, const String & access_key_id, const String & secret_access_key);