thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-20 08:40:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Better code in unit tests

Browse Source
This commit is contained in:
Alexey Milovidov 2019-07-08 04:58:15 +03:00
parent 03712aabec
commit ac20c515ab
19 changed files with 4 additions and 93 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dbms/CMakeLists.txt
View File

@ -387,6 +387,10 @@ if (ENABLE_TESTS AND USE_GTEST)
# attach all dbms gtest sources # attach all dbms gtest sources
grep_gtest_sources(${ClickHouse_SOURCE_DIR}/dbms dbms_gtest_sources) grep_gtest_sources(${ClickHouse_SOURCE_DIR}/dbms dbms_gtest_sources)
add_executable(unit_tests_dbms ${dbms_gtest_sources}) add_executable(unit_tests_dbms ${dbms_gtest_sources})
# gtest framework has substandard code
target_compile_options(unit_tests_dbms PRIVATE -Wno-zero-as-null-pointer-constant -Wno-undef -Wno-sign-compare -Wno-used-but-marked-unused)
target_link_libraries(unit_tests_dbms PRIVATE ${GTEST_BOTH_LIBRARIES} clickhouse_functions clickhouse_parsers dbms clickhouse_common_zookeeper) target_link_libraries(unit_tests_dbms PRIVATE ${GTEST_BOTH_LIBRARIES} clickhouse_functions clickhouse_parsers dbms clickhouse_common_zookeeper)
add_check(unit_tests_dbms) add_check(unit_tests_dbms)
endif () endif ()

6
dbms/src/Columns/tests/column_unique.cpp
View File

@ -7,12 +7,6 @@
#include <DataTypes/DataTypesNumber.h> #include <DataTypes/DataTypesNumber.h>
#include <DataTypes/DataTypeNullable.h> #include <DataTypes/DataTypeNullable.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <unordered_map> #include <unordered_map>

5
dbms/src/Common/ZooKeeper/tests/gtest_zkutil_test_multi_exception.cpp
View File

@ -5,11 +5,6 @@
#include <iostream> #include <iostream>
#include <chrono> #include <chrono>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Common/ShellCommand.h> #include <Common/ShellCommand.h>

5
dbms/src/Common/tests/gtest_rw_lock.cpp
View File

@ -1,8 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Common/RWLock.h> #include <Common/RWLock.h>

5
dbms/src/Common/tests/gtest_shell_command.cpp
View File

@ -9,11 +9,6 @@
#include <chrono> #include <chrono>
#include <thread> #include <thread>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>

5
dbms/src/Common/tests/gtest_thread_pool_concurrent_wait.cpp
View File

@ -1,10 +1,5 @@
#include <Common/ThreadPool.h> #include <Common/ThreadPool.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
/** Reproduces bug in ThreadPool. /** Reproduces bug in ThreadPool.

5
dbms/src/Common/tests/gtest_thread_pool_limit.cpp
View File

@ -2,11 +2,6 @@
#include <iostream> #include <iostream>
#include <Common/ThreadPool.h> #include <Common/ThreadPool.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
/// Test for thread self-removal when number of free threads in pool is too large. /// Test for thread self-removal when number of free threads in pool is too large.

5
dbms/src/Common/tests/gtest_thread_pool_loop.cpp
View File

@ -2,11 +2,6 @@
#include <iostream> #include <iostream>
#include <Common/ThreadPool.h> #include <Common/ThreadPool.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>

5
dbms/src/Common/tests/gtest_thread_pool_schedule_exception.cpp
View File

@ -2,11 +2,6 @@
#include <stdexcept> #include <stdexcept>
#include <Common/ThreadPool.h> #include <Common/ThreadPool.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>

5
dbms/src/Common/tests/gtest_unescapeForFileName.cpp
View File

@ -1,10 +1,5 @@
#include <Common/escapeForFileName.h> #include <Common/escapeForFileName.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>

5
dbms/src/Compression/tests/gtest_compressionCodec.cpp
View File

@ -20,11 +20,6 @@
#include <bitset> #include <bitset>
#include <string.h> #include <string.h>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
using namespace DB; using namespace DB;

6
dbms/src/DataStreams/tests/gtest_blocks_size_merging_streams.cpp
View File

@ -1,9 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Core/Block.h> #include <Core/Block.h>
#include <Columns/ColumnVector.h> #include <Columns/ColumnVector.h>

5
dbms/src/DataTypes/tests/gtest_data_type_get_common_type.cpp
View File

@ -4,11 +4,6 @@
#include <sstream> #include <sstream>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>

5
dbms/src/IO/tests/gtest_aio_seek_back_after_eof.cpp
View File

@ -1,10 +1,5 @@
#if defined(__linux__) || defined(__FreeBSD__) #if defined(__linux__) || defined(__FreeBSD__)
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Core/Defines.h> #include <Core/Defines.h>

6
dbms/src/IO/tests/gtest_bit_io.cpp
View File

@ -16,12 +16,6 @@
#include <typeinfo> #include <typeinfo>
#include <iostream> #include <iostream>
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
using namespace DB; using namespace DB;

5
dbms/src/IO/tests/gtest_cascade_and_memory_write_buffer.cpp
View File

@ -1,8 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <stdexcept> #include <stdexcept>

5
dbms/src/Storages/tests/gtest_aux_funcs_for_adaptive_granularity.cpp
View File

@ -1,8 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Core/Block.h> #include <Core/Block.h>
#include <Columns/ColumnVector.h> #include <Columns/ColumnVector.h>

5
dbms/src/Storages/tests/gtest_row_source_bits_test.cpp
View File

@ -1,8 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <DataStreams/ColumnGathererStream.h> #include <DataStreams/ColumnGathererStream.h>

5
dbms/src/Storages/tests/gtest_transform_query_for_external_database.cpp
View File

@ -1,8 +1,3 @@
#pragma GCC diagnostic ignored "-Wsign-compare"
#ifdef __clang__
#pragma clang diagnostic ignored "-Wzero-as-null-pointer-constant"
#pragma clang diagnostic ignored "-Wundef"
#endif
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <Storages/transformQueryForExternalDatabase.h> #include <Storages/transformQueryForExternalDatabase.h>