From acc1613e3b3db57d61db27e28762aed8f1bbfc53 Mon Sep 17 00:00:00 2001 From: Alexey Milovidov Date: Wed, 21 Sep 2022 05:28:47 +0200 Subject: [PATCH] Fix wrong exception code in the bitmapTransform function --- src/Functions/FunctionsBitmap.h | 5 +++-- .../02430_bitmap_transform_exception_code.reference | 0 .../0_stateless/02430_bitmap_transform_exception_code.sql | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) create mode 100644 tests/queries/0_stateless/02430_bitmap_transform_exception_code.reference create mode 100644 tests/queries/0_stateless/02430_bitmap_transform_exception_code.sql diff --git a/src/Functions/FunctionsBitmap.h b/src/Functions/FunctionsBitmap.h index 1e48588892a..c6d221f743d 100644 --- a/src/Functions/FunctionsBitmap.h +++ b/src/Functions/FunctionsBitmap.h @@ -20,12 +20,13 @@ // inside. #include + namespace DB { namespace ErrorCodes { extern const int ILLEGAL_TYPE_OF_ARGUMENT; - extern const int LOGICAL_ERROR; + extern const int BAD_ARGUMENTS; } /** Bitmap functions. @@ -640,7 +641,7 @@ private: } if (from_end - from_start != to_end - to_start) - throw Exception("From array size and to array size mismatch", ErrorCodes::LOGICAL_ERROR); + throw Exception("From array size and to array size mismatch", ErrorCodes::BAD_ARGUMENTS); col_to->insertDefault(); AggregateFunctionGroupBitmapData & bitmap_data_2 diff --git a/tests/queries/0_stateless/02430_bitmap_transform_exception_code.reference b/tests/queries/0_stateless/02430_bitmap_transform_exception_code.reference new file mode 100644 index 00000000000..e69de29bb2d diff --git a/tests/queries/0_stateless/02430_bitmap_transform_exception_code.sql b/tests/queries/0_stateless/02430_bitmap_transform_exception_code.sql new file mode 100644 index 00000000000..5a30f9598e9 --- /dev/null +++ b/tests/queries/0_stateless/02430_bitmap_transform_exception_code.sql @@ -0,0 +1 @@ +SELECT bitmapTransform(arrayReduce('groupBitmapState', [1]), [1, 2], [1, 2, 3]); -- { serverError BAD_ARGUMENTS }