thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-21 23:21:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix endless loop for parsing invalid test hints (lack of ss.fail() check)

Browse Source
This commit is contained in:
Azat Khuzhin 2021-08-08 20:08:36 +03:00
parent d39128df9f
commit ad4833b4ab
1 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
programs/client/TestHint.cpp
View File

@ -8,6 +8,33 @@
namespace DB
{
namespace ErrorCodes
{
extern const int CANNOT_PARSE_TEXT;
}
}
namespace
{
int parseErrorCode(std::stringstream & ss) // STYLE_CHECK_ALLOW_STD_STRING_STREAM
{
using namespace DB;
int code;
ss >> code;
if (ss.fail())
throw Exception(ErrorCodes::CANNOT_PARSE_TEXT,
"Expected integer value for test hint, got: '{}'", ss.str());
return code;
}
}
namespace DB
{
TestHint::TestHint(bool enabled_, const String & query_)
: query(query_)
{
@ -63,9 +90,9 @@ void TestHint::parse(const String & hint, bool is_leading_hint)
if (!is_leading_hint)
{
if (item == "serverError")
ss >> server_error;
server_error = parseErrorCode(ss);
else if (item == "clientError")
ss >> client_error;
client_error = parseErrorCode(ss);
}
if (item == "echo")