thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-23 16:12:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move scale factor pull out of the parsing loop

Browse Source
This commit is contained in:
Francisco Javier Jurado Moreno 2024-05-28 09:26:07 +02:00
parent 8d684cef3b
commit ad647786a1
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Functions/fromReadable.h
View File

@ -70,6 +70,8 @@ public:
"Illegal column {} of first ('str') argument of function {}. Must be string.",
arguments[0].column->getName(),
getName());
std::unordered_map<std::string_view, Float64> scale_factors = Impl::getScaleFactors();
auto col_res = ColumnFloat64::create(input_rows_count);
@ -84,7 +86,7 @@ public:
std::string_view str = col_str->getDataAt(i).toView();
try
{
auto num_bytes = parseReadableFormat(str);
auto num_bytes = parseReadableFormat(scale_factors, str);
res_data[i] = num_bytes;
}
catch (...)
@ -111,7 +113,7 @@ private:
throw Exception(code, "Invalid expression for function {} - {} (\"{}\")", getName(), msg, arg);
}
Float64 parseReadableFormat(const std::string_view & str) const
Float64 parseReadableFormat(const std::unordered_map<std::string_view, Float64> & scale_factors, const std::string_view & str) const
{
ReadBufferFromString buf(str);
// tryReadFloatText does seem to not raise any error when there is leading whitespace so we check it explicitly
@ -129,7 +131,6 @@ private:
if (!buf.eof())
throwException(ErrorCodes::UNEXPECTED_DATA_AFTER_PARSED_VALUE, "Found trailing characters after readable size string", str);
boost::algorithm::to_lower(unit);
std::unordered_map<std::string_view, Float64> scale_factors = Impl::getScaleFactors();
auto iter = scale_factors.find(unit);
if (iter == scale_factors.end())
{