thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-22 17:50:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

better

Browse Source
This commit is contained in:
Nikita Mikhailov 2021-01-21 02:25:31 +03:00 committed by Nikita Mikhaylov
parent a596227a02
commit adfb2885c9
8 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/Access/SettingsProfileElement.cpp
View File

@ -28,7 +28,6 @@ void SettingsProfileElement::init(const ASTSettingsProfileElement & ast, const A
if (id_mode)
return parse<UUID>(name_);
assert(manager);
/// NOLINTNEXTLINE(clang-analyzer-core.CallAndMessage)
return manager->getID<SettingsProfile>(name_);
};

1
src/Common/remapExecutable.cpp
View File

@ -26,7 +26,6 @@ namespace ErrorCodes
namespace
{
// NOLINTNEXTLINE(cert-dcl50-cpp)
__attribute__((__noinline__)) int64_t our_syscall(...)
{
__asm__ __volatile__ (R"(

1
src/Functions/FunctionHelpers.cpp
View File

@ -220,7 +220,6 @@ checkAndGetNestedArrayOffset(const IColumn ** columns, size_t num_arguments)
else if (*offsets_i != *offsets)
throw Exception("Lengths of all arrays passed to aggregate function must be equal.", ErrorCodes::SIZES_OF_ARRAYS_DOESNT_MATCH);
}
/// NOLINTNEXTLINE(clang-analyzer-core.CallAndMessage)
return {nested_columns, offsets->data()};
}

1
src/Functions/array/arrayUniq.cpp
View File

@ -172,7 +172,6 @@ ColumnPtr FunctionArrayUniq::executeImpl(const ColumnsWithTypeAndName & argument
auto res = ColumnUInt32::create();
ColumnUInt32::Container & res_values = res->getData();
/// NOLINTNEXTLINE(clang-analyzer-core.CallAndMessage)
res_values.resize(offsets->size());
if (num_arguments == 1)

1
src/Functions/formatString.h
View File

@ -248,7 +248,6 @@ struct FormatImpl
/// Strings without null termination.
for (size_t i = 1; i < substrings.size(); ++i)
{
/// NOLINTNEXTLINE(clang-analyzer-core.CallAndMessage)
final_size += data[index_positions[i - 1]]->size();
/// Fixed strings do not have zero terminating character.
if (offsets[index_positions[i - 1]])

1
src/IO/readDecimalText.h
View File

@ -181,7 +181,6 @@ inline void readDecimalText(ReadBuffer & buf, T & x, uint32_t precision, uint32_
/// Too many digits after point. Just cut off excessive digits.
auto divisor = intExp10OfSize<typename T::NativeType>(divisor_exp);
assert(divisor > 0); /// This is for Clang Static Analyzer. It is not smart enough to infer it automatically.
/// NOLINTNEXTLINE(clang-analyzer-core.DivideZero)
x.value /= divisor;
scale = 0;
return;

1
src/Storages/StorageFactory.cpp
View File

@ -185,7 +185,6 @@ StoragePtr StorageFactory::get(
{
/// Storage creator modified empty arguments list, so we should modify the query
assert(storage_def && storage_def->engine && !storage_def->engine->arguments);
/// NOLINTNEXTLINE(clang-analyzer-core.NullDereference)
storage_def->engine->arguments = std::make_shared<ASTExpressionList>();
storage_def->engine->children.push_back(storage_def->engine->arguments);
storage_def->engine->arguments->children = empty_engine_args;

1
src/Storages/System/StorageSystemQuotaUsage.cpp
View File

@ -171,7 +171,6 @@ void StorageSystemQuotaUsage::fillDataImpl(
for (auto resource_type : ext::range(Quota::MAX_RESOURCE_TYPE))
{
const auto & type_info = ResourceTypeInfo::get(resource_type);
/// NOLINTNEXTLINE(clang-analyzer-core.CallAndMessage)
addValue(*column_max[resource_type], *column_max_null_map[resource_type], interval->max[resource_type], type_info);
addValue(*column_usage[resource_type], *column_usage_null_map[resource_type], interval->used[resource_type], type_info);
}