Get rid of IAST::getQueryKindString

src/Interpreters/executeQuery.cpp

@@ -57,6 +57,8 @@
 #include <Processors/Executors/CompletedPipelineExecutor.h>
 #include <Processors/Sources/WaitForAsyncInsertSource.h>
 
+#include <base/EnumReflection.h>
+
 #include <random>
 
 
@@ -271,7 +273,7 @@ static void onExceptionBeforeStart(const String & query_for_logging, ContextPtr
     // Try log query_kind if ast is valid
     if (ast)
     {
-        elem.query_kind = ast->getQueryKindString();
+        elem.query_kind = magic_enum::enum_name(ast->getQueryKind());
         if (settings.log_formatted_queries)
             elem.formatted_query = queryToString(ast);
     }

src/Parsers/ASTAlterQuery.h

@@ -246,7 +246,6 @@ public:
         return removeOnCluster<ASTAlterQuery>(clone(), new_database);
     }
 
-    const char * getQueryKindString() const override { return "Alter"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Alter; }
 
 protected:

src/Parsers/ASTCreateQuery.h

@@ -113,7 +113,6 @@ public:
 
     bool isView() const { return is_ordinary_view || is_materialized_view || is_live_view || is_window_view; }
 
-    const char * getQueryKindString() const override { return "Create"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Create; }
 
 protected:

src/Parsers/ASTDropQuery.h

@@ -45,7 +45,6 @@ public:
         return removeOnCluster<ASTDropQuery>(clone(), new_database);
     }
 
-    const char * getQueryKindString() const override { return "Drop"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Drop; }
 
 protected:

src/Parsers/ASTInsertQuery.h

@@ -66,7 +66,6 @@ public:
         return res;
     }
 
-    const char * getQueryKindString() const override { return "Insert"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Insert; }
 
 protected:

src/Parsers/ASTRenameQuery.h

@@ -65,7 +65,6 @@ public:
         return query_ptr;
     }
 
-    const char * getQueryKindString() const override { return "Rename"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Rename; }
 
 protected:

src/Parsers/ASTSelectIntersectExceptQuery.h

@@ -22,7 +22,6 @@ public:
 
     void formatImpl(const FormatSettings & settings, FormatState & state, FormatStateStacked frame) const override;
 
-    const char * getQueryKindString() const override { return "SelectIntersectExcept"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::SelectIntersectExcept; }
 
     ASTs getListOfSelects() const;

src/Parsers/ASTSelectQuery.h

@@ -135,7 +135,6 @@ public:
 
     void setFinal();
 
-    const char * getQueryKindString() const override { return "Select"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Select; }
 
 protected:

src/Parsers/ASTSelectWithUnionQuery.h

@@ -17,7 +17,6 @@ public:
 
     void formatQueryImpl(const FormatSettings & settings, FormatState & state, FormatStateStacked frame) const override;
 
-    const char * getQueryKindString() const override { return "Select"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::Select; }
 
     SelectUnionMode union_mode;

src/Parsers/ASTSystemQuery.h

@@ -107,7 +107,6 @@ public:
         return removeOnCluster<ASTSystemQuery>(clone(), new_database);
     }
 
-    const char * getQueryKindString() const override { return "System"; }
     virtual QueryKind getQueryKind() const override { return QueryKind::System; }
 
 protected:

src/Parsers/Access/ASTGrantQuery.h

@@ -34,7 +34,6 @@ public:
     void replaceEmptyDatabase(const String & current_database);
     void replaceCurrentUserTag(const String & current_user_name) const;
     ASTPtr getRewrittenASTWithoutOnCluster(const std::string &) const override { return removeOnCluster<ASTGrantQuery>(clone()); }
-    const char * getQueryKindString() const override { return is_revoke ? "Revoke" : "Grant"; }
     virtual QueryKind getQueryKind() const override { return is_revoke ? QueryKind::Revoke : QueryKind::Grant; }
 };
 }

src/Parsers/IAST.h

@@ -245,9 +245,6 @@ public:
 
     void cloneChildren();
 
-    // Return query_kind string representation of this AST query.
-    virtual const char * getQueryKindString() const { return ""; }
-
     enum QueryKind
     {
         None,