From fcfaf82181f97d888e4ddccd0754c80e31e7f567 Mon Sep 17 00:00:00 2001
From: Jayme Bird <jayme.bird@clickhouse.com>
Date: Tue, 9 Apr 2024 17:49:46 +0100
Subject: [PATCH] fix: add missing hostname column to blob_storage_log system
 table

---
 docs/en/operations/system-tables/blob_storage_log.md | 2 ++
 src/Interpreters/BlobStorageLog.cpp                  | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/docs/en/operations/system-tables/blob_storage_log.md b/docs/en/operations/system-tables/blob_storage_log.md
index 2328f7f0346..8c0c33a504a 100644
--- a/docs/en/operations/system-tables/blob_storage_log.md
+++ b/docs/en/operations/system-tables/blob_storage_log.md
@@ -7,6 +7,7 @@ Contains logging entries with information about various blob storage operations
 
 Columns:
 
+- `hostname` ([LowCardinality(String)](../../sql-reference/data-types/string.md)) — Hostname of the server executing the query.
 - `event_date` ([Date](../../sql-reference/data-types/date.md)) — Date of the event.
 - `event_time` ([DateTime](../../sql-reference/data-types/datetime.md)) — Time of the event.
 - `event_time_microseconds` ([DateTime64](../../sql-reference/data-types/datetime64.md)) — Time of the event with microseconds precision.
@@ -38,6 +39,7 @@ SELECT * FROM system.blob_storage_log WHERE query_id = '7afe0450-504d-4e4b-9a80-
 ```text
 Row 1:
 ──────
+hostname:                clickhouse.eu-central1.internal
 event_date:              2023-10-31
 event_time:              2023-10-31 16:03:40
 event_time_microseconds: 2023-10-31 16:03:40.481437
diff --git a/src/Interpreters/BlobStorageLog.cpp b/src/Interpreters/BlobStorageLog.cpp
index f9d5b0d6790..0324ef8713c 100644
--- a/src/Interpreters/BlobStorageLog.cpp
+++ b/src/Interpreters/BlobStorageLog.cpp
@@ -1,4 +1,5 @@
 #include <Interpreters/BlobStorageLog.h>
+#include <base/getFQDNOrHostName.h>
 
 #include <DataTypes/DataTypesNumber.h>
 #include <DataTypes/DataTypeString.h>
@@ -26,6 +27,7 @@ ColumnsDescription BlobStorageLogElement::getColumnsDescription()
 
     return ColumnsDescription
     {
+        {"hostname", std::make_shared<DataTypeLowCardinality>(std::make_shared<DataTypeString>()), "Hostname of the server executing the query."},
         {"event_date", std::make_shared<DataTypeDate>(), "Date of the event."},
         {"event_time", std::make_shared<DataTypeDateTime>(), "Time of the event."},
         {"event_time_microseconds", std::make_shared<DataTypeDateTime64>(6), "Time of the event with microseconds precision."},
@@ -51,6 +53,7 @@ void BlobStorageLogElement::appendToBlock(MutableColumns & columns) const
     size_t i = 0;
 
     auto event_time_seconds = timeInSeconds(event_time);
+    columns[i++]->insert(getFQDNOrHostName());
     columns[i++]->insert(DateLUT::instance().toDayNum(event_time_seconds).toUnderType());
     columns[i++]->insert(event_time_seconds);
     columns[i++]->insert(Decimal64(timeInMicroseconds(event_time)));