Make the naming a little less confusing

This commit is contained in:
Robert Schulze 2023-02-02 19:16:25 +00:00
parent 5d9687f5d9
commit b1889b0284
No known key found for this signature in database
GPG Key ID: 26703B55FB13728A
3 changed files with 11 additions and 11 deletions

View File

@ -1518,8 +1518,7 @@ try
global_context->setMMappedFileCache(mmap_cache_size);
/// A cache for query results.
global_context->setQueryCache();
global_context->updateQueryCacheConfiguration(config());
global_context->setQueryCache(config());
#if USE_EMBEDDED_COMPILER
/// 128 MB

View File

@ -2041,7 +2041,7 @@ void Context::dropIndexMarkCache() const
shared->index_mark_cache->reset();
}
void Context::setQueryCache()
void Context::setQueryCache(const Poco::Util::AbstractConfiguration & config)
{
auto lock = getLock();
@ -2049,6 +2049,14 @@ void Context::setQueryCache()
throw Exception(ErrorCodes::LOGICAL_ERROR, "Query cache has been already created.");
shared->query_cache = std::make_shared<QueryCache>();
shared->query_cache->updateConfiguration(config);
}
void Context::updateQueryCacheConfiguration(const Poco::Util::AbstractConfiguration & config)
{
auto lock = getLock();
if (shared->query_cache)
shared->query_cache->updateConfiguration(config);
}
QueryCachePtr Context::getQueryCache() const
@ -2064,13 +2072,6 @@ void Context::dropQueryCache() const
shared->query_cache->reset();
}
void Context::updateQueryCacheConfiguration(const Poco::Util::AbstractConfiguration & config)
{
auto lock = getLock();
if (shared->query_cache)
shared->query_cache->updateConfiguration(config);
}
void Context::setMMappedFileCache(size_t cache_size_in_num_entries)
{
auto lock = getLock();

View File

@ -861,7 +861,7 @@ public:
void dropMMappedFileCache() const;
/// Create a cache of query results for statements which run repeatedly.
void setQueryCache();
void setQueryCache(const Poco::Util::AbstractConfiguration & config);
void updateQueryCacheConfiguration(const Poco::Util::AbstractConfiguration & config);
std::shared_ptr<QueryCache> getQueryCache() const;
void dropQueryCache() const;